zen-lang / zen

Library for model driven systems
115 stars 12 forks source link

v2 validator: remove slice-name from data :path #28

Closed carbon-hvze closed 2 years ago

carbon-hvze commented 2 years ago

if slicing validation is applied :path key in an error contains slice name like ["[slice]" 0 :slice-key] https://github.com/zen-lang/zen/blob/master/pkg/zen/tests/slicing-test.edn#L386

:path by definition should be a valid path in data so slice-name should be removed

carbon-hvze commented 2 years ago

@KGOH you mentioned once that some implementation might depend on this behaviour, can you please reiterate?

I can implement the change in no time but I want to check for compatibility first

carbon-hvze commented 2 years ago

@KGOH please check if tests fail on your side when you have a minute