Closed KCNilssen closed 1 year ago
Fixes Issue #194 and Issue #195
Standings model attribute Teamrecords was updated to include
eliminationnumbersport: str eliminationnumberleague: str eliminationnumberdivision: str eliminationnumberconference: str
Which were missing due to an update with the mlb api. Mock_json test json file was also updated to reflect these updates.
Game model livedata/boxscore attribute PlayersDictPerson was updated to make position optional
position: Optional[Union[Position, dict]] = None | self.position = Position(**self.position) if self.position else self.position
This was made optional due to a Tyler Brown playing for Minnesota in gameid 719391 not having a position attribute.
Live + mocktests updated and ran. Both pass 100%
Normal risk, normal impact.
Why
Fixes Issue #194 and Issue #195
What
Standings model attribute Teamrecords was updated to include
Which were missing due to an update with the mlb api. Mock_json test json file was also updated to reflect these updates.
Game model livedata/boxscore attribute PlayersDictPerson was updated to make position optional
This was made optional due to a Tyler Brown playing for Minnesota in gameid 719391 not having a position attribute.
Tests
Live + mocktests updated and ran. Both pass 100%
Risk and impact
Normal risk, normal impact.