zero-sum-seattle / python-mlb-statsapi

Python Wrapper for the MLB's Official Stats API
MIT License
44 stars 11 forks source link

Update ScheduleGame with gameguid, Homerunderby info with nongameguid… #199

Closed mgbeck002 closed 1 year ago

mgbeck002 commented 1 year ago

…, and Game break fields

Why

Getting errors with version 0.5.13 when getting schedule with an unexpected gameguid field. This identified other unexpected fields, in total:

What

Add the following fields:

Updated the mock test data to reflect new output.

Tests

Tested using mocked and external tests.

Risk and impact

What is the risk level of the change and why?

What is the impact if something does go wrong with this PR? - minimal since these endpoints were having issues with version 0.5.13

Mattsface commented 1 year ago

Thanks for the MR I will review when I get home tonight

mgbeck002 commented 1 year ago

Thanks for the feedback. Those test files have been updated.

Mattsface commented 1 year ago

Let's version bump it too 0.5.14 and call it good. Thanks for the PR. Can you do that @mgbeck002?