search

zerojay / RetroPie-Extra

A collection of unofficial scripts for adding more emulators/ports/games to RetroPie.
MIT License
311 stars 103 forks source link

Please not use cmake in manalus package #237

Closed 4144 closed 6 years ago

4144 commented 7 years ago

Cmake build system is legacy in manaplus, and may works not effective. It missing all flags, and can works only with SDL 1.2. Better use automake/autoconf. It allow use SDL1.2 or SDL2, and select different other libs

https://github.com/zerojay/RetroPie-Extra/blob/428ec9690f51421730ba51ba5b36a3d12541f628/scriptmodules/ports/manaplus.sh#L27

symbios24 commented 7 years ago

it seems the creator is out for vacations he is not answering anything.

zerojay commented 7 years ago

Sorry, my pi's memory card died and I've been swamped at work. I'll get to this shortly.

On Tue, Sep 19, 2017 at 4:23 AM, symbios24 notifications@github.com wrote:

it seems the creator is out for vacations he is not answering anything.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zerojay/RetroPie-Extra/issues/237#issuecomment-330466529, or mute the thread https://github.com/notifications/unsubscribe-auth/AAmdndjdsdUs2EjsN7LoKTfnLVnucOXeks5sj3odgaJpZM4PTZBj .

zerojay commented 7 years ago

I'd also accept a pull request for the change.

zerojay commented 6 years ago

Should now be fixed.