search

zerojay / RetroPie-Extra

A collection of unofficial scripts for adding more emulators/ports/games to RetroPie.
MIT License
307 stars 99 forks source link

fix(rocksndiamonds): use working git clone method and compile target #357

Closed mstempell closed 2 years ago

zerojay commented 2 years ago

Unfortunately, if gitPullOrClone isn't working for you, that indicates that there are far bigger problems on your end. The method is still used all over RetroPie, so this wouldn't really fix anything except for you. I would suggest taking a look at what is stopping gitPullOrClone from working for you instead.

This goes against Retropie's standards, so I won't be accepting but thanks for the PR anyways.

mstempell commented 2 years ago

OK then, but for information the git clone problem occurred on a fresh Retropie install.

Complete error being:

git clone --recursive --depth 1 --branch master "https://git.artsoft.org/rocksndiamonds.git" "/home/pi/RetroPie-Setup/tmp/build/rocksndiamonds"
Cloning into '/home/pi/RetroPie-Setup/tmp/build/rocksndiamonds'...
fatal: dumb http transport does not support shallow capabilities
HEAD is now in branch 'master' at commit 'b070a366d659581ed5fd8317258a64e4c030f5da'
Error running 'git clone --recursive --depth 1 --branch master https://git.artsoft.org/rocksndiamonds.git /home/pi/RetroPie-Setup/tmp/build/rocksndiamonds' - returned 128
/home/pi

Also another corrected problem in the PR is that the defined build target "sdl2" doesn't exist in the latest project makefile. You may want to correct that.