search

zesterer / tao

A statically-typed functional language with generics, typeclasses, sum types, pattern-matching, first-class functions, currying, algebraic effects, associated types, good diagnostics, etc.
https://tao.jsbarretto.com/
Mozilla Public License 2.0
1.09k stars 23 forks source link

Clippy fixes #49

Open matthiasbeyer opened 1 year ago

matthiasbeyer commented 1 year ago

WIP!!!

This is a WIP effort to fix all clippy fixes in the project. It is based on #48, so that PR should clearly go in first, I will then rebase this one.

It is nowhere done, there's a lot reported by clippy. I am just opening this so that you can see what I am doing :sweat_smile:

netlify[bot] commented 1 year ago

Deploy Preview for thriving-beignet-855860 ready!

Name Link
Latest commit 09daafbdc09122bcbe64e9f3ec152bb46e90794a
Latest deploy log https://app.netlify.com/sites/thriving-beignet-855860/deploys/640b058083eb0400085a310c
Deploy Preview https://deploy-preview-49--thriving-beignet-855860.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

matthiasbeyer commented 1 year ago

Cleaned up, rebased and "clippy-clean" IMO.

48 should go in first still, though! :laughing:

zesterer commented 1 year ago

This PR seems to remove several things that were unused, but with intent to use later. While I think clippy is usually a useful tool and very useful on projects in a more mature state, I don't think many of these changes do much to help this particular codebase, with some actually doing it some harm.