search

zhukic / Sectioned-RecyclerView

Simple Android library that allows you to easily split your RecyclerView into expanding/collapsing sections with headers.
Apache License 2.0
130 stars 25 forks source link

Request: remove the "allowBackup" attribute from manifest of the library #8

Closed AndroidDeveloperLB closed 7 years ago

AndroidDeveloperLB commented 7 years ago

This:

<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="zhukic.library">

    <application android:allowBackup="true"
        android:supportsRtl="true">

    </application>

</manifest>

It causes issue when importing to a project that has it set to false:

Error:Execution failed for task ':app:processSyncmeappDebugManifest'.
> Manifest merger failed : Attribute application@allowBackup value=(false) from AndroidManifest.xml:48:9-36
    is also present at [com.github.zhukic:sectioned-recyclerview:1.0.0] AndroidManifest.xml:12:9-35 value=(true).
    Suggestion: add 'tools:replace="android:allowBackup"' to <application> element at AndroidManifest.xml:46:5-852:19 to override.

Please just remove it. It's an optional flag...

zhukic commented 7 years ago

Hi, @AndroidDeveloperLB. I have removed application tag in manifest. Try out 1.0.1 version. Thanks for issue.

AndroidDeveloperLB commented 7 years ago

Good thanks.