zipMoney / zip.magento2

Zip Payment Extension for Magento2 that support global zip products
MIT License
4 stars 9 forks source link

Magento/Adobe Commerce 2.4.6 compatibility #86

Open alevashov opened 1 year ago

alevashov commented 1 year ago

When do you plan to release a version compatible with Magento 2.4.6?

lytesaber commented 1 year ago

Adobe has also dropped PHP 7.4 support and introduced compatibility with PHP 8.2 in Magento / Adobe Commerce 2.4.6 so this must also be catered for in an updated 2.4.6 compatible version of the Zip Magento 2 module.

lytesaber commented 1 year ago

Testing the latest version of Zip 1.2.2 against Magento 2.4.6 & PHP 8.2 the whole cart / checkout process is broken when the zip payment method is enabled. The following error is thrown in Magento's system.log

cmain.CRITICAL: Deprecated Functionality: Creation of dynamic property Zip\ZipPayment\Model\Config::$_urlBuilder is deprecated in /var/www/html/vendor/zip/magento2/Model/Config.php on line 306 [] []

alevashov commented 1 year ago

I've Tweeted about the issue, here is the answer I've got:

Hi @Magenable 👋

Thank you for reaching out, I've passed on your interest to our team.

Keep an eye out for notifications regarding our app updates 👀

If you would like to chat further regarding this, please feel free to reach out via private message 📨

Thanks, Kyle 😁


Not really encouraging :(

alevashov commented 1 year ago

Hi Zip team

any updates, when may we expect the fix?

bawwwa commented 1 year ago

Here is a patch I did for version 1.2.2 to fix issues with magento 2.4.6.

zip-money.patch

The below should fix the issue above.

--- a/vendor/zip/magento2/Model/Config.php  2022-08-25 13:23:56.000000000 +1000
+++ b/vendor/zip/magento2/Model/Config.php  2023-06-06 11:56:51.235993621 +1000
@@ -284,8 +284,16 @@
      */
     protected $_locale;

+    /**
+     * @var \Magento\Framework\Module\ModuleListInterface
+     */
     protected $_moduleList;

+    /**
+     * @var \Magento\Framework\UrlInterface
+     */
+    protected $_urlBuilder;
+
     public function __construct(
         \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
         \Magento\Store\Model\StoreManagerInterface $storeManager,