alevashov
commented
1 year ago Already reported 3 weeks ago, previous issue #86
But ZIP doesn't look to be in hurry to fix it (
Open luantran1311 opened 1 year ago
alevashov
commented
1 year ago Already reported 3 weeks ago, previous issue #86
But ZIP doesn't look to be in hurry to fix it (
luantran1311
commented
1 year ago hi @alevashov
I saw them fix it yesterday in this branch https://github.com/zipMoney/zip.magento2/tree/feature/BPI-291/fixed-issue-to-support-m2-latest-version
alevashov
commented
1 year ago Oh, good to see progress, guess it hasn't been tested yet. Keep fingers crossed it works well and we'll see a release soon.
bawwwa
commented
1 year ago Here is a patch I did for version 1.2.2 to fix issues with magento 2.4.6.
The below should fix the issue above.
--- a/vendor/zip/magento2/Block/Advert/AbstractAdvert.php 2022-08-25 13:23:56.000000000 +1000
+++ b/vendor/zip/magento2/Block/Advert/AbstractAdvert.php 2023-06-06 11:53:42.663557376 +1000
@@ -4,6 +4,7 @@
use Zip\ZipPayment\Model\Config;
use Magento\Framework\Pricing\PriceCurrencyInterface;
+use \Magento\Framework\Currency;
/**
* @category Zip
@@ -118,7 +119,7 @@ public function getCurrencyFormat($price)
{
$objectManager = \Magento\Framework\App\ObjectManager::getInstance();
$currency = $objectManager->get(\Magento\Directory\Model\Currency::class);
- return $currency->format($price, ['display' => \Zend_Currency::NO_SYMBOL], false);
+ return $currency->format($price, ['display' => Currency::NO_SYMBOL], false);
}
public function getCurrencySymbol()
Can you please make this compatible with Magento 2.4.6? Got the below error on product page