search

zkr024 / Leaderboard

0 stars 0 forks source link

Peer to peer code Review #2

Open NeckerFree opened 2 years ago

NeckerFree commented 2 years ago

To highlight: A well organized structure

In the file addToList.js, please use a variable to store the result of the function storeRecords() for no repeat the invocation.

Img x

memelopez commented 2 years ago

https://github.com/zkr024/Leaderboard/blob/c918ade1c03683afdf9b3aca6427d661734794b5/src/modules/variables.js#L1-L4

Good Idea to put all the important variables of the document in a separate module. an improvement could be encapsulating them all in an object and, that way you export the object only.