search

zloirock / core-js

Standard Library
MIT License
24.59k stars 1.66k forks source link

Get rid of postinstall message #548

Closed jpike88 closed 5 years ago

jpike88 commented 5 years ago

My installation log isn't for advertising space. If you want donations, please do the right thing and promote yourself in places where appropriate. My logs are long enough as it is without this.

The right thing to do is to remove it.

EDIT: An unmaintained fork is available: core-js-without-ads

nicolo-ribaudo commented 5 years ago

You can hide it using the --loglevel silent (or warn, or error) npm option:

npm i --loglevel silent

Package authors have the right to ask users to support their projects. If people are going to be angry about it, they can choose to use a commercial product which doesn't have to ask for funds, instead of a free one.

jpike88 commented 5 years ago

It's called donationware and it sets a bad precedent. Loglevel flags shouldn't be the solution to this, it's a misuse of their purpose.

I hope you see where I'm coming from. Please keep it where it belongs, otherwise a high profile package like this will start a trend that nobody wants.

TomLingham commented 5 years ago

@jpike88 it's free software. Once you start paying for it, maybe then you can dictate what is logged during installation. Otherwise, fork it and alias the dependency in your project if you feel so passionately about it.

jpike88 commented 5 years ago

Nobody is dictating anything. It's called encouraging good practices, and instead of being so defensive you can consider what I'm saying on its merits. Or you don't have to, it's open source right ;) everyone's free to say what they want

TomLingham commented 5 years ago

I'm not being defensive. Merely encouraging good social practices (to use your own words). It's not unusual for these post install messages to be in packages installed through npm so saying that you are encouraging "good practices" is not founded in anything substantial.

jpike88 commented 5 years ago

https://github.com/cssinjs/jss/issues/881 https://github.com/remy/nodemon/issues/1189 https://github.com/styled-components/styled-components/issues/1590 https://github.com/pouchdb/pouchdb/issues/7392

This discussion has played itself out in a few other repos, the trend is almost always the reconsidering of whether it's even an effective marketing tactic, and whether it's fair to the developers who utilise it. The move is then reversed. It is a highly unusual thing to do, and the blowback tends to be strong. Otherwise we'd be seeing every 10th or 20th package doing it (thank god we don't).

If you're not sure what I mean by 'good practices', you can read those links.

TomLingham commented 5 years ago

I appreciate you digging those up, but there are actually a lot of packages that do it

It's up to the maintainer - if it doesn't benefit them like you say, then I'm sure they'll change it in time. Just be glad they aren't mining crypto during the install 😂

jpike88 commented 5 years ago

A miner would definitely make this complaint look small... lol

jackturnbull commented 5 years ago

My preference would be to keep the post-install messages clean; I see them as a good place to advertise recent breaking changes and knowing the size of most node_modules folders, if everyone starts doing it then we're in for a rough ride. But with that being said I respect that it's @zloirock's right to use it to ask for a little help. Hell, I'm using hundreds if not thousands of contributors' time so I think I'll survive.

I don't think I'll be the only one here but @jpike88 you've made it really difficult to thumbs up this post with the tone of the message. Nearly every sentence is self-absorbed, outright hostile, or reads as command.

zloirock commented 5 years ago

Dear @jpike88!

Almost 5 years almost every day I spend some hour for maintenance core-js. It's not a library from some lines which I can write and forget about it - it should react on any change in JavaScript standard or proposals, on any new JS engine release, on any significant bug in JS engines. core-js has become the de facto standard of JavaScript standard library features polyfill.

I was working on the project in my spare time. No one paid me for it, more other - I didn't use it actively in my work, I worked on it since I thought that it was required for JavaScript community. No one of browser vendors, TC39, big companies which use core-js helped me. Users started actively contribute to this project only some months ago.

Some previous months I worked almost fulltime on core-js@3 and polyfilling-related Babel features instead of making money as I thought it was important for JavaScript community and planned to find a new fulltime work after release.

2 months ago I started raising funds to core-js maintenance. Current result - 7$ / month on Patreon, 50$ / month on Open Collective. Not seriously, but better than nothing - users use Babel or their frameworks for polyfilling and just don't know that they use core-js indirectly. Not a problem since anyway I didn't think about open source as about a way to earn any serious money.

However, shit happens. Because of one accident, now I have some serious problems for tens or even hundreds of thousands of dollars and a real chance to be in prison - doubtful pleasure - interesting, who will maintain core-js in this case? Since previous months I worked on open source, I have not any financial pillow for solving those problems.

After a little discussion, I understood that I can't count to any help from Babel. Nothing to say.

So why not to make this little experiment? I think that some lines in NPM installation log, which can be hidden if it's required, are an acceptable price for using core-js. I don’t think that I’ll be able to get a however significant part of required at this moment money, however, each dollar makes sense. And some more people will know that I am ready to consider job offers.

And after that, someone says that I'm not right because I added a message on postinstall... The right thing for you is somehow supporting core-js instead of creating issues like this.

Initially, I wanted to add a message on postinstall as an experiment for some days, but because of your reaction I see that adding a message on postinstall was the right thing, so I leave it here. Thank you for this issue.

Let this issue be opened a little more time.

papandreou commented 5 years ago

This is rage-inducing. What if everybody did that?

Anaphase commented 5 years ago

I don't mind donation messages at all, but this little message at the end really bugs me:

Also, the author of core-js (https://github.com/zloirock) is looking for a good job -)

Is that really necessary?

TomLingham commented 5 years ago

@papandreou @Anaphase I was going to tap out of this conversation because I'd already made my point, however your entitlement is deafening. "It really bugs me", or "This is rage-inducing" are the faulty reasonings of individuals who are unable to muster even one modicum of empathy.

It sent a few extra lines through your stdout - if that is what keeps you up at night, then you've clearly lost all perspective.

papandreou commented 5 years ago

Whereas ad hominem attacks are signs of...?

TomLingham commented 5 years ago

Ok, so maybe that wasn't entirely called for - but the author has already explained themselves. Your feelings don't matter, neither do mine. Why continue to beat a dead horse? 🤔

jpike88 commented 5 years ago

LOL... I predicted there would be blowback.

@jackturnbull not my intention to offend, and the way I talk may be nicer than the way I type. Not my intention to 'command' or insult anyone.

And @zloirock holy crap I don't even know what to say there... good luck I guess. This library is used by the angular cli and pretty much all of the angular community, I think you're going to continue to find more attention over time.

IdanAdar commented 5 years ago

With respect, it's fine to advertise... but WHY SO MUCH? Once, twice... three times, but this? Disgusting.

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-core/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-generator/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helper-bindify-decorators/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helper-builder-binary-assignment-operator-visitor/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helper-call-delegate/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helper-define-map/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helper-explode-assignable-expression/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helper-explode-class/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helper-function-name/node_modules/core-js
> node scripts/postinstall

(node:517) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 SIGINT listeners added. Use emitter.setMaxListeners() to increase limit
Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helper-get-function-arity/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helper-hoist-variables/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helper-optimise-call-expression/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helper-regex/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helper-remap-async-to-generator/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helper-replace-supers/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-helpers/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-messages/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-check-es2015-constants/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-async-generator-functions/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-async-to-generator/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-class-constructor-call/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-class-properties/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-decorators/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-arrow-functions/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-block-scoped-functions/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-block-scoping/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-classes/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-computed-properties/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-destructuring/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-duplicate-keys/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-for-of/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-function-name/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-literals/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-modules-amd/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-modules-commonjs/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-modules-systemjs/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-modules-umd/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-object-super/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-parameters/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-shorthand-properties/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-spread/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-sticky-regex/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-template-literals/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-typeof-symbol/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-es2015-unicode-regex/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-exponentiation-operator/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-export-extensions/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-object-rest-spread/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-regenerator/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-plugin-transform-strict-mode/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-register/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-template/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-traverse/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@2.6.7 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/babel-types/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js@3.1.1 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/core-js
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)

> core-js-pure@3.1.1 postinstall /home/jenkins/workspace/Dashboard_PR-851/node_modules/core-js-pure
> node scripts/postinstall

Thank you for using core-js ( https://github.com/zloirock/core-js )!

Please consider supporting of core-js on Open Collective or Patreon: 
> https://opencollective.com/core-js 
> https://www.patreon.com/zloirock 

Also, the author of core-js ( https://github.com/zloirock ) is looking for a good job -)
TomLingham commented 5 years ago

@IadnAdar that is pretty verbose. I think that comes from many different packages depending on core-js. It's interesting to see just how many packages depend on it. Perhaps if you can suggest a way of limiting it to logging just once? 🤔

IdanAdar commented 5 years ago

Whomever added it to "make cash" / "advertise self", that is the person who should take a good look at him/herself and suggest a fix.

... Just show it once at the top before whatever process is happening takes place.

TomLingham commented 5 years ago

Sometimes people need to make money off things they normally do for free just for the love of it. It's just the way it is - maybe if more people would donate, then it might not be needed?

Post install is run after installing for every dependant package. Because it is so important in the ecosystem, that is why you are seeing the message so much. The author has already explained themselves in this issue. Have you read through the comments here already? I suggested forking and aliasing the package further up in this thread, perhaps give that a shot if it's causing you too much trouble right now.

IdanAdar commented 5 years ago

Yes, I read the thread and the reasoning is very thin...

Annoying users as a tool get donations only serves for the opposite. Psychology 101. Right now I am so aggravated I'm not even going to consider what this was "supposed to achieve".

There is a way to get something, and this is done poorly and in bad taste. Good luck.

Anaphase commented 5 years ago

Whoooo boy this is getting heated! I just wanted to chime in again and say that there's nothing really wrong with asking for donations, this is free software and we shouldn't be bitching about it. If the verbose logs really bug you, just silence them like @nicolo-ribaudo said with npm install --loglevel warn. You can put this in your .npmrc so it runs every time, because honestly do you really need the output of an npm install aside from warnings & errors?

That being said, I still think it's in poor taste to have the last line asking to get hired. @zloirock should have that on his opencollective / patreon / github pages for interested parties, but it's wholly inappropriate to include in a postinstall message.

Anyway, I've now become a Patron of @zloirock on Patreon, thanks for all your hard work 👍

kopax commented 5 years ago

I am not a fan of postinstall advertisment but after reading your story, I just want to say I hope you will get through, and thanks for the big work. People should not blame too much others when it's about free and more over good work.

ibnuda commented 5 years ago

let me jump into the bandwagon.

zloirock, let's say that money (or opportunity) solves issues. so, at what price will you remove those lines? and jpike88 and friends should try to haggle that price down from their perceived value until equilibrium reached and then followed by paying zloirock that same amount of money (or opportunity).

win win? fair? you decide!

Anaphase commented 5 years ago

@ibnuda don't forget, someone has to give him a job too! 😂

lazarljubenovic commented 5 years ago

Everyone is saying how it is free and that's why the author can do whatever he wants. And yet so many people are browsing ad-powered websites for free, but use AdBlock to hide them.

Whether it annoys you or not, why deny the simple truth that postinstall message (which is usually one among hundreds) is not a place to post donation banners? Postinstall message is a place to inform me about the package being deprecated or if it has a security issue. It's a developer's log, full with information about installation, not a blog post.

People who are willing to give money to support a project are going to search for the project name and see the donation button/banner on the website/readme long before they even think about donating. Or do you expect people to use their credit cards through command line?

nathanjd commented 5 years ago

I'm a bit confused as to what I would be supporting with these donations. In another thread, you cited

It was related to my current burnout and problems

@rjgotten now I lost any motivation to work on it or another babel features. So no concrete timeline.

as the reason for this.

https://github.com/zloirock/core-js/issues/496

I have two main questions which are sadly personal in nature but seem relevant.

  1. Why would you choose to quit your job to start working full time on something you have burnt out on and seem increasingly annoyed by?
  2. Would my donations be going towards legal fees for some harm that you have caused? I understand that an accident can cause unemployment and high medical bills itself but from your wording, you seem to be at fault.

Because of one accident, now I have some serious problems for tens or even hundreds of thousands of dollars and a real chance to be in prison - doubtful pleasure - interesting, who will maintain core-js in this case?

If you are in prison, who will maintain it then?

zloirock commented 5 years ago

@nathanjd

  1. Because at that moment I didn't think that Babel would betray me? I worked on polyfilling stuff for Babel almost from the start of the project, but when I asked about any help and it was really required - I received a refusal.

  2. Seems so, thanks to our stupid law.

If you are in prison, who will maintain it then?

See above - I haven't any options.

tfavorite commented 5 years ago

What is exit code -2? Installing babel and anything else that depends on this seems to fail in certain cases (not sure which, been spending the past day trying to find that out) running this postinstall script. Putting the install on quiet mode doesn't help either. I'm downgrading to version 2.6.4 until I figure this out....

1253 silly lifecycle core-js@2.6.8~postinstall: Args: [ '-c',
1253 silly lifecycle   'node -e "try { require(\'./scripts/postinstall\'); } catch (e) { /* empty */ }"' ]
1254 info lifecycle core-js@2.6.8~postinstall: Failed to exec postinstall script
1255 silly lifecycle core-js@2.6.8~postinstall: Returned: code: -2  signal: null
1256 info lifecycle core-js@2.6.8~postinstall: Failed to exec postinstall script

Best of luck with your current troubles.

silverwind commented 5 years ago

It seems this postinstall script causes my Docker builds on Alpine Linux to get stuck while cross-compiling a application for ARMv6 (works on x64 though):

$ docker run --rm -it arm32v6/node:alpine sh
/ # mkdir test && cd test && npm i core-js

> core-js@3.1.2 postinstall /test/node_modules/core-js
> node -e "try { require('./scripts/postinstall'); } catch (e) { /* empty */ }"

It hangs forever with one CPU core at 100% usage.

nathonius commented 5 years ago

Perhaps it would be good to follow opencollective-postinstall and allow for a specific env variable to suppress the message? https://github.com/opencollective/opencollective-postinstall#disabling-this-message

zloirock commented 5 years ago

@OfficerHalf since it's not Open Collective only, I don't think that DISABLE_OPENCOLLECTIVE env variable makes sense. But this script already suppressed this message with CI variable or with the changed log level.

Ok, personally for you, I'll add support of ADBLOCK env variable -)

zloirock commented 5 years ago

@tfavorite @silverwind I think that it not a place for those issues, they should be moved to separate threads. Also, please, provide more info or reproducible examples.

@tfavorite theoretically, here can help just adding || true to postinstall command, however, for some reason I avoided it. Maybe makes sense to add it.

@silverwind now I haven't any ARMv6 test env. Feel free to propose a fix for it.

tfavorite commented 5 years ago

Thanks for your quick reply @zloirock - if I can figure out the exact scenario that leads to it (and it's not some user error) I'll report a separate issue with more detail.

IdanAdar commented 5 years ago

Here, use this: https://github.com/sponsors and please keep our build logs clean.

nathanjd commented 5 years ago

@zloirock,

I'm sorry to hear that, though you avoided answering my second question.

Thank you for adding the ADBLOCK environment variable and for your significant contributions to the community to date.

timoxley commented 5 years ago

IMO if you are benefitting from @zloirock's work for free, he can put whatever the shit he wants in your install logs, stop acting so entitled.

jalovatt commented 5 years ago

@timoxley If the message could be scoped to the people directly using it, that would make sense. I see them because Babel and Storybook use it - should I also have to see nag screens if any of their devs are using the free version of Sublime 3?

All the best to the author, but there are better ways to go about this. Why not set up a GoFundMe and try to get word-of-mouth going on Twitter or something?

nicolo-ribaudo commented 5 years ago

Babel is not using core-js internally. It's exposing it to its users.

jalovatt commented 5 years ago

Then perhaps Babel should compensate the author for bundling his work under their name, given a) how popular Babel is, and b) the fact that they're using an external library for doing The Thing Babel Is Known For Doing.

rjgotten commented 5 years ago

@jalovatt Then perhaps Babel should compensate the author

Straight to the heart of the matter. Sadly the short of it is: they don't seem to want to. As was written by the author before:

@zloirock After a little discussion, I understood that I can't count to any help from Babel. Nothing to say.

jpike88 commented 5 years ago

@jalovatt this project is open sourced under the MIT license, Babel nor any other party is obligated to compensate or give back to the maintainers of this project in any way, nor should they be expected to. If you provide something for free with no strings attached, you shouldn't expect anything from those to make use of it, no matter who they are.

Inconvenient? Cold? Maybe. But that's how it works.

kopax commented 5 years ago

Jesus, @jpike88 I don't think this was about obligation but I believe they talk about empathy. Open source is also a visit card, if babel is an organization that hire software enginners, why can't @zloirock be hired if he's free and qualified.

rjgotten commented 5 years ago

@kopax I don't think this was about obligation but I believe they talk about empathy.

That, really.

Let's face fact here: the adoption rate of Babel would plummet if it would only transpile language features and would not polyfill the base library -- which is really, really freakin' hard to do correctly and which would've taken Babel's direct contributors and development team a lot of effort if they'd have to have done all of it themselves.

@zloirock deserves some recognition from Babel for saving them that work.

Just because they don't have to do anything here contractually; doesn't mean they cannot do so. It's their choice not to do anything here. And that choice paints them as one of those evil old IT overlord corporations that open source as a philosophy was so against. Which is somewhat ironic; because they're only able to make this choice because of the openness of open-source te begin with.

jpike88 commented 5 years ago

Of course @zloirock deserves recognition for such a great library, nobody is against that as an idea here. But it's important to recognise the reality of the situation. He has a pretty solid CV from leading this project alone, how many people can say that Angular/Babel uses their library? That puts him way ahead of the vast majority of candidates out there. If he's not getting much success, maybe his strategies need adjusting, or the job market sucks (that one I doubt). He could waltz into an IT exhibition and land a few interviews without even trying.

But I don't know why Babel deserves any negative reception here, they are already flush with capable devs, and while they have a decent list of sponsors, their patreon is only getting about $3000 USD. That's not much at all, they might be pretty tight themselves.

jalovatt commented 5 years ago

@jpike88 But I don't know why Babel deserves any negative reception here, they are already flush with capable devs, and while they have a decent list of sponsors, their patreon is only getting about $3000 USD. That's not much at all, they might be pretty tight themselves.

I don't think "negative reception" is the right idea. "Peer pressure", maybe? They're using core-js. Babel users are using Babel, which exposes core-js to save themselves a lot of work - no problem there, that's what open source is for, but if Babel, Storybook, Angular, and whoever else are doing well for themselves while the author of one of their major dependencies is struggling, IMO that's a problem that (morally) they should be helping to fix.

That doesn't necessarily mean "give the author money", since as you say they may not be flush with cash themselves, but they're in a much better position to pass the hat for him, or try to help him find employment.

runspired commented 5 years ago

Log pollution is a problem, especially for newer developers that have no idea what they are reading when things go wrong. Let's not make that problem worse. If even 1% of commonly used libraries did this project installs would have completely unusable logs.

Imagine the pain seen by @IdanAdar but several orders of magnitude worse as the status-quo. This is not the usability story we wish for the language, for the web, or for any dev team of any experience level.

Just one repository abusing the postinstall hook in this manner is too many.

The suggestion made to silence all logs because a transient dependency has decided to take up a mile's worth of screen real estate during an install is equally abusive. No one library should be able to dictate an all-or-nothing log level.

I am very much for donations and support, but this is not the way to do it. This is the postinstall hook equivalent of attempting to use GPL to hold other libraries, products, and companies hostage.

etoxin commented 5 years ago

This is currently clogging up my logs and adding no value to my project.

lazarljubenovic commented 5 years ago

IMO if you are benefitting from @zloirock's work for free, he can put whatever the shit he wants in your install logs, stop acting so entitled.

Ouch. Looks like someone needs a refresher on the difference between CAN and SHOULD.

And why is he entitled to put "whatever the shit he wants" in my install logs, but I'm not entitled to put "whatever the shit" complaints I want in his GitHub issues?

inradius commented 5 years ago

Also, this is causing our npm ci to fail right when it gets to this message.