zoontek / react-native-dev-menu

Add custom items to the React Native dev menu.
MIT License
204 stars 25 forks source link

Include required React's subspecs as dependencies #8

Closed barbosa closed 5 years ago

barbosa commented 5 years ago

Default React pod does not include DevSupport subspec as a dependency by default.

Having only React listed here raises the following compilation error:

▸ Compiling RNDevMenu.m

❌  /Users/me/Developer/project/node_modules/react-native-dev-menu/ios/RNDevMenu.m:1:9: 'React/RCTDevMenu.h' file not found

#import <React/RCTDevMenu.h>

After including React/DevSupport as an additional subspec, it raises:

▸ Compiling RCTBlobManager.mm

❌  /Users/me/Developer/project/node_modules/react-native/Libraries/Blob/RCTBlobManager.mm:13:9: 'React/RCTNetworking.h' file not found

#import <React/RCTNetworking.h>

So we have to also include React/RCTNetwork (which is also not included in React/Core).

zoontek commented 5 years ago

Thanks!