zopefoundation / cipher.encryptingstorage

ZODB storage wrapper for encryption of database records
Other
5 stars 8 forks source link

Config with pure python #9

Closed icemac closed 3 years ago

icemac commented 3 years ago

The tests are currently broken – I fixed some by adding use_extension_bytes = True but the other ones break on different code.

Does anyone have an idea how to fix this?

icemac commented 3 years ago

Strange, locally (on MacOS) I get the following failures: (But only on Python 2.7!)

Failure in test checkFlushNeededAfterTruncate (cipher.encryptingstorage.tests.test_zodb.FileStorageZlibTests)
Traceback (most recent call last):
  File ".../lib/python2.7/unittest/case.py", line 329, in run
    testMethod()
  File ".../cipher.encryptingstorage/.tox/py27/lib/python2.7/site-packages/ZODB/tests/testFileStorage.py", line 327, in checkFlushNeededAfterTruncate
    self.checkFlushAfterTruncate(True)
  File ".../cipher.encryptingstorage/.tox/py27/lib/python2.7/site-packages/ZODB/tests/testFileStorage.py", line 314, in checkFlushAfterTruncate
    b'foo' if fail else b'bar')
  File ".../lib/python2.7/unittest/case.py", line 513, in assertEqual
    assertion_func(first, second, msg=msg)
  File ".../lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual
    raise self.failureException(msg)
AssertionError: 'bar' != 'foo'

Failure in test checkFlushNeededAfterTruncate (cipher.encryptingstorage.tests.test_zodb.FileStorageZlibTestsWithBlobsEnabled)
Traceback (most recent call last):
  File ".../lib/python2.7/unittest/case.py", line 329, in run
    testMethod()
  File ".../cipher.encryptingstorage/.tox/py27/lib/python2.7/site-packages/ZODB/tests/testFileStorage.py", line 327, in checkFlushNeededAfterTruncate
    self.checkFlushAfterTruncate(True)
  File ".../cipher.encryptingstorage/.tox/py27/lib/python2.7/site-packages/ZODB/tests/testFileStorage.py", line 314, in checkFlushAfterTruncate
    b'foo' if fail else b'bar')
  File ".../lib/python2.7/unittest/case.py", line 513, in assertEqual
    assertion_func(first, second, msg=msg)
  File ".../lib/python2.7/unittest/case.py", line 506, in _baseAssertEqual
    raise self.failureException(msg)
AssertionError: 'bar' != 'foo'
vincentfretin commented 3 years ago

I'm not using this package anymore, the project where I was using it is dead now. Sorry, I won't be able to review or help with this.

icemac commented 3 years ago

@vincentfretin Thank you for informing. I removed you from the reviewers list.

icemac commented 3 years ago

Thank you for reviewing this PR. 😃