Make setupstack.txt work again if cwd is empty

zopefoundation / zope.testing

Other

4 stars 13 forks source link

Make setupstack.txt work again if cwd is empty #33

Closed cjwatson closed 3 years ago

cjwatson commented 3 years ago

z3c.recipe.compattest apparently runs tests with an empty current directory, so we need a slightly different approach to prove that setUpDirectory actually changes directory. (Regressed in 4.8.)

Noticed due to https://github.com/zopefoundation/zopetoolkit/pull/50.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 465916510

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 56.14%

Totals
Change from base Build 461502405:	0.0%
Covered Lines:	368
Relevant Lines:	649

💛 - Coveralls

cjwatson commented 3 years ago

Merged, thanks. If you could release 4.8.1 when you get a minute, that would be great.

icemac commented 3 years ago

I am going to cut a release now.

icemac commented 3 years ago

The release came out as 4.9 as I was running fullrelease --no-input and the change of the version number was not in setup.py which I did not consider, sorry. See https://pypi.org/project/zope.testing/4.9/

cjwatson commented 3 years ago

My mistake for not updating setup.py. Thanks.