zpropheter / Jamf-Log-Grabber

Finds logs and plists related to Jamf management settings
46 stars 8 forks source link

Custom app logs are not gathered #35

Closed elior-esh closed 1 month ago

elior-esh commented 1 month ago

Describe the bug Custom app logs are not gathered. I tried gathering logs for App Auto Patch and Nudge. The results HTML states that the folders were deleted as part of the cleanup array as they were empty.

To Reproduce Steps to reproduce the behavior:

  1. In Jamf Log Grabber policy in Jamf Pro define custom apps name and directory
  2. Run Jamf Log Grabber via Self Service
  3. Examine results

Expected behavior I expected to see the logs in the output folder of Jamf Log Grabber under the respective custom app names.

Screenshots Screenshot 2024-07-18 at 11 23 44 Screenshot 2024-07-18 at 11 25 09 Screenshot 2024-07-18 at 11 25 44

Environment (please complete the following information):

zpropheter commented 1 month ago

Hi @elior-esh

Sorry to hear you're having this issue. Can you check the following lines that may need to be uncommented? Should be line 869-879. Default turns it off as there were some errors that were confusing others during collection. Simply remove the # from the "CustomApp#Array".

`"$CustomApp1Name")

Add or Remove comment from line below to disable or enable the array for the custom app

            #CustomApp1Array  
        ;;
        "$CustomApp2Name")
            #Add or Remove comment from line below to disable or enable the array for the custom app
            #CustomApp2Array  
        ;;
        "$CustomApp3Name")
            #Add or Remove comment from line below to disable or enable the array for the custom app
            #CustomApp3Array  

`

zpropheter commented 1 month ago

@elior-esh Let me know if that works or not. I'm going to be out of town tomorrow afternoon but happy to take a look at this for you before then if that section already has the comments removed. If so, can you attach the script as you have it pasted into self service for my reference?

elior-esh commented 1 month ago

@zpropheter apologies! You were correct and untagging those lines solved it. PEBCAK 🤦

zpropheter commented 1 month ago

@elior-esh glad it was a simple solution. I'll close this out for now.