search

zpropheter / Jamf-Log-Grabber

Finds logs and plists related to Jamf management settings
48 stars 8 forks source link

Create a license.md file #39

Open Rocketman-Chris opened 1 week ago

Rocketman-Chris commented 1 week ago

Amazing tool! I don't see a license file anywhere (please direct me if you have one) but I am creating another tool that uploads logs to Jamf Pro (among other things) and came across this tool. I was wondering if we could implement a flag in our Jamf Tool called --jamfLogGrabber which would upload these logs to the user's computer record in Jamf Pro. We'd be happy to credit you in the Jamf logs and in our documentation.

This is a Jamf only tool that would be free, but likely be distributed as closed-source (we're still figuring that out, but some of our clients prefer closed-source).

Thank you!

zpropheter commented 1 week ago

Hi @Rocketman-Chris, This is a tough one. I'm looking into it and okay with open source use, however the workflow you're describing is not what this tool is intended for. Using the computer record to upload logs into Jamf Pro is a perilous workflow and I wouldn't be okay with having this get implemented into a workflow like that due to the database issues it has caused and continues to cause when admins do that.

I had that outlined in a previous version, not sure when it got lost but I'll add it back is it's a pretty big concern. Please reconsider your implementation and possibly incorporate something more like what this blog outlines: https://derflounder.wordpress.com/2020/10/16/remotely-gathering-sysdiagnose-files-and-uploading-them-to-s3/

Rocketman-Chris commented 1 week ago

Yeah that's a good point... I'd often do this just to grab the jamf.log on rare occasions, but this grabs a lot more logs, and if you ran it on 100s of Macs it would probably crash your server...

Whelp, guess I will be rethinking this tool! Not sure if I want to utilize the S3 bucket or something else. Maybe upload it as a Jamf package? it would be a little bit weird, but now that you can download them... it's basically the same as an S3 bucket, but the user doesn't need to set it up. What do you think?

zpropheter commented 1 week ago

I don't think it would introduce too many complications but I'm hesitant to sign endorse a non-standard workflow to get them into the DB. JCDS has had its own set of problems lately so I'm also hesitant based on that.

In any workflow that utilizes Jamf Pro as the repository the biggest concern is maintenance, if the workflow allows auto upload into the server, that bloat can accumulate quickly. I'd be curious to see an implementation that considers cleanup as part of it too rather than just the initial upload so admins don't let it get put to the side long term.