search

zscaler / zpa-openshift

MIT License
0 stars 1 forks source link

Support not only OpenShift #2

Open MPV opened 4 weeks ago

MPV commented 4 weeks ago

Would you be up for adding/changing/supporting a non-OpenShift-only helm chart?

As it is today, I guess it's only the SecurityContextConstraints resource that isn't portable to vanilla Kubernetes (?), i.e:

drew0ps commented 3 weeks ago

Hi @MPV,

My thoughts exactly, that is why I added https://github.com/zscaler/zpa-openshift/pull/1 to make the flag .Values.zsglobal.securityContextConstraints.create work. I've installed it on a local vanilla Kube cluster and for me it seems to work.

MPV commented 1 week ago

Now that the changes coming in #1 are on the way, as it will thus support not-only OpenShift, could this repo also be renamed (for discoverability) to reflect that the helm chart could work with vanilla Kubernetes as well?

Also considering the documentation on the Docker page saying Kubernetes isn't supported:

"Docker support is not available for Kubernetes." https://help.zscaler.com/zpa/app-connector-deployment-guide-docker

MPV commented 1 week ago

Would you also say/recommend that the zsglobal.openshiftEnvironment.value value should be set to some (which?) other value than enabled?

https://github.com/zscaler/zpa-openshift/blob/5b08eb732045948e711ac3ad9f2b253be80af64a/values.yaml#L144-L147

https://github.com/zscaler/zpa-openshift/blob/5b08eb732045948e711ac3ad9f2b253be80af64a/templates/deployment.yaml#L49-L50