Bioconductor / Contributions

Contribute Packages to Bioconductor
134 stars 33 forks source link

alabaster.schemas #2894

Closed LTLA closed 1 year ago

LTLA commented 1 year ago

Update the following URL to point to the GitHub repository of the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

I am familiar with the essential aspects of Bioconductor software management, including:

For questions/help about the submission process, including questions about the output of the automatic reports generated by the SPB (Single Package Builder), please use the #package-submission channel of our Community Slack. Follow the link on the home page of the Bioconductor website to sign up.

bioc-issue-bot commented 1 year ago

Additional Package has been approved for building.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/alabaster.spatial to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Additional Package has been approved for building.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot commented 1 year ago

Additional Package has been approved for building.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/alabaster.bumpy to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/alabaster.mae to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Additional Package has been approved for building.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/alabaster.string to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Additional Package has been approved for building.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/alabaster.vcf to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Additional Package has been approved for building.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

lshep commented 1 year ago

All the package should now be in git.bioconductor.org . Please push changes to fix dependency error's.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/alabaster to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

LiNk-NY commented 1 year ago

Hi Aaron, @LTLA

OK, maybe there's a bug in BiocCheck... @LiNk-NY ? Anyway the pre-check is passed, it will be in the single-package builder soon.

alabaster.spatial has luna@gene.com which is not registered on the support site: https://github.com/ArtifactDB/alabaster.spatial/blob/30ad7a45460359685dbf11245339df7df386dad6/DESCRIPTION#L11

See also: https://support.bioconductor.org/api/email/luna@gene.com/

cc: @vjcitn

lshep commented 1 year ago

I was afraid my comments might get lost in the build report messages so moving them to the end here: -

  1. just FYI alabaster.string and alabaster.spatial use luna@gene.com as maintainer email while the rest are infinite.monkeys.with.keyboards@gmail.com (also pointed out with support site registration)
  2. alabater.ranges http://staging.bioconductor.org:8000/job/18413/ : there is no package called ‘jsonvalidate’ -- I think you need to declare in your DESCRIPTION of alabaster.ranges -- I assume this is why the error's propagate through the rest of the build reports for the subsequent packages
  3. 'chihaya-R' http://staging.bioconductor.org:8000/job/18416/ Its a requirement of the BBS that the repo name and the package name in the DESCRIPTION match.
hpages commented 1 year ago

Hi @LTLA ,

This is a big stack of packages. I wonder if it couldn't be broken down into groups to try to make the review process a little bit easier to manage. For example into 4 groups (I guess there are other ways to break this down, this is just one possibility):

1. Not really part of the alabaster stack:

2. Bottom half of the alabaster stack:

3. Top half of the alabaster stack:

4. Sitting at the top of the stack (umbrella package):

Each group could be done in a separate submission. Of course group N+1 cannot be submitted until group N is accepted, so the entire process might take slightly longer (but hopefully not too much).

Do you think this could make the submission process somehow easier to manage? Or does this split feel too artificial?

H.

lshep commented 1 year ago

@hpages @vjcitn suggested they all be submitted together in a private slack thread and now that they are in git and in the spb database it might be a bit of a mess to try to separate out and re-add

hpages commented 1 year ago

Ah ok, seems like I'm late to the party :grinning: Nevermind.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: f340a03198b40ddc15af0dca420f7b2416d0ea3d

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: d6c6d696ce8efb48ccb828e98d1e63b43924b1d9

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/alabaster.string to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

LTLA commented 1 year ago

Thanks all, responses below.

1. just FYI alabaster.string and alabaster.spatial use luna@gene.com as maintainer email while the rest are infinite.monkeys.with.keyboards@gmail.com (also pointed out with support site registration)

Fixed.

2. alabater.ranges http://staging.bioconductor.org:8000/job/18413/ : there is no package called ‘jsonvalidate’ -- I think you need to declare in your DESCRIPTION of alabaster.ranges -- I assume this is why the error's propagate through the rest of the build reports for the subsequent packages

There should already be a Suggests dependency on jsonvalidate in alabaster.base. Surely I don't have to list transitive dependencies? Otherwise I've got a whole bunch of packages that would need to Suggests: statmod when pulling in edgeR and using the QL functions, and I don't recall having to do that.

I'll note that I deliberately set jsonvalidate as a Suggests as (i) it is only needed for writing objects, so people who are only reading from existing databases don't need it, and (ii) it's a minor pain to install, as it depends on the V8 package and thus the system libraries of the same name.

3. 'chihaya-R' http://staging.bioconductor.org:8000/job/18416/ Its a requirement of the BBS that the repo name and the package name in the DESCRIPTION match.

This is mildly problematic because https://github.com/LTLA/chihaya is already in use; it's the underlying C++ library that feeds into various interfaces (e.g., R, Javascript). I can't rename that one, either, because various CMake scripts are fetching from that URL to build other things. Renaming the R package to the "expected" repo URL would break those scripts.

What does the repo name matter? It's not like BioC is syncing to the GitHub repo anyway.

This is a big stack of packages. I wonder if it couldn't be broken down into groups to try to make the review process a little bit easier to manage. For example into 4 groups (I guess there are other ways to break this down, this is just one possibility):

Yes, on hindsight that would probably have been a better idea. I also forgot about chihaya until I had started the process, so I just had to throw it in to get artificer.matrix to CHECK.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "ERROR". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/alabaster.spatial to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

vjcitn commented 1 year ago

Please use chihayaR as the name of repo and of package. We need congruency between package name and repo name, it is in the guidelines. Additionally the declarations have to be sufficient for the build system to report OK. We appreciate the contributions but have to work within the current parameters of the build system, we cannot introduce new exceptions.

vjcitn commented 1 year ago

Of course if you prefer some other name, that is fine, but repo name and package name must agree and be valid.

LTLA commented 1 year ago

Hm. Well, for the time being, maybe you can switch it to https://github.com/ArtifactDB/chihaya instead.

lshep commented 1 year ago

Can you please use the additonalpackages format so we can process everything correctly. I will work on removing chihaya-R in the meantime

LTLA commented 1 year ago

AdditionalPackage: https://github.com/ArtifactDB/chihaya

bioc-issue-bot commented 1 year ago

Hi @LTLA, Thanks for submitting your additional package: https://github.com/ArtifactDB/chihaya. We are taking a quick look at it and you will hear back from us soon.

bioc-issue-bot commented 1 year ago

Additional Package has been approved for building.

IMPORTANT: Please read this documentation for setting up remotes to push to git.bioconductor.org. It is required to push a version bump to git.bioconductor.org to trigger a new build.

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/chihaya to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

vjcitn commented 1 year ago

Apropos jsonvalidate, if it is not installed, a user of the package will not be able to run the vignette code in alabaster.string. So I think jsonvalidate should be declared in alabaster.string and in any package that will fail check when it is not declared.

vjcitn commented 1 year ago

The argument concerning burden of installing jsonvalidate is, I think, nugatory for mac and windows users, and for linux the difficulties will be mitigated when the r2u discipline is adopted for bioc packages ... stay tuned.

LTLA commented 1 year ago

So I think jsonvalidate should be declared in alabaster.string and in any package that will fail check when it is not declared.

Which would basically be every alabaster package. Seems unreasonable to ask all the other alabaster packages to break alabaster.base's abstraction by meddling in the implementation details of how the validation is done.

For submission purposes, I don't mind moving jsonvalidate to an Imports in alabaster.base, but I can't guarantee that it'll stay there - the installation burden of V8 system libraries is not insignificant in my experience. It's likely that I will eventually move it back to a Suggests and just add a nicer error message to instruct users to install jsonvalidate if they attempt to stage an object without that package being installed.

The argument concerning burden of installing jsonvalidate is, I think, nugatory for mac and windows users

Well, to provide a counterexample: I don't install binaries on my mac, I always build from source. I don't think I've ever used the binaries when I was working on a mac in the past 8 years.

More generally - while the binaries (and r2u) could be treated as a mitigation for the installation burden, that's all it is, a mitigation. Better to just solve it at the source by not requiring installation in the first place.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: a8fb60b9a977b7ebbb6bd1fb4a952e7121668f04

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/alabaster.base to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: b445b1a95e80db4fa2673d0c52d774a3b49c713a

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/alabaster.base to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 27eacf939df4b3592e55c171c3e470c0f5ca2352

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/chihaya to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: e77077a3cfffb818baf6c98c6bae80233bcc8f41

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/alabaster.matrix to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 4670811b234184fc3353ff870a9ac3bfdf2f5d82

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/alabaster.base to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 07c3ab83cf42a3da0b5d7f87bb51c34c5e3e5f82

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

On one or more platforms, the build results were: "WARNINGS". This may mean there is a problem with the package that you need to fix. Or it may mean that there is a problem with the build system itself.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/chihaya to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: 31d772e2d1e363fd068dc112a571f996581881ec

bioc-issue-bot commented 1 year ago

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on Linux, Mac, and Windows.

Congratulations! The package built without errors or warnings on all platforms.

Please see the build report for more details. This link will be active for 21 days.

Remember: if you submitted your package after July 7th, 2020, when making changes to your repository push to git@git.bioconductor.org:packages/alabaster.schemas to trigger a new build. A quick tutorial for setting up remotes and pushing to upstream can be found here.

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: adb40874afe9d49ab0fd27fe88e2bbed09af3eb2

bioc-issue-bot commented 1 year ago

Received a valid push on git.bioconductor.org; starting a build for commit id: fc95188583a36df2e4797dc779e38006855ce9bc