Botspot / pi-apps

Raspberry Pi App Store for Open Source Projects
GNU General Public License v3.0
1.96k stars 202 forks source link

Install button broken #1970

Closed ghost closed 2 years ago

ghost commented 2 years ago

Confirmations

What happened?

Install button doesn't work

Description

If I press the install button on ANY app, it wont work.

What is your operating system?

Raspberry Pi OS Bullseye armhf with KDE Plasma

(Optional) Error log? Terminal output? Debug messages?

No response

Edit: for people having the same issue, try changing your default terminal, look below for further information

github-actions[bot] commented 2 years ago

Hello there 👋 Thanks for submitting your first issue to the Pi-Apps project! We'll try to get back to you as soon as possible. In the meantime, we encourage you join our Discord server, where you can ask any questions you might have.

ghost commented 2 years ago

I should also mention I tried adding a app, and running the script also didn't work, so I'm unsure if my install scripts work. (I'm new to bash and stuff)

ghost commented 2 years ago

Just now I tried to manually update Pi Apps and every time it pops up, it shows the items again, meaning not even updating works.

theofficialgman commented 2 years ago

if this is your first time running pi-apps, make sure that you actually properly installed it by running this script https://github.com/Botspot/pi-apps#install-pi-apps

if you attempted to install via some other method, please list it here now

ghost commented 2 years ago

I had it installed since I got my Pi, just recently I installed plasma (I was using the default desktop before).

ghost commented 2 years ago

Okay, I did a clean re-install of Pi Apps, and it still doesn't work. I ran it through the terminal, and when I tried to install an app, I got this: image (I pressed the button twice since it appeared twice since I clicked a bunch of times)

Botspot commented 2 years ago

I got this: image

Perfect! That's what error messages are for.

@tedmakesstuff, let's find what terminal you have installed. To do that, please run this command:

readlink -f "$(command -v x-terminal-emulator)"
Botspot commented 2 years ago

@tedmakesstuff, could you also run this command?

DEBUG=1 ~/pi-apps/etc/terminal-run

This will tell us which terminal the terminal-run script decided to use. On my system, the output is "Using lxterminal from x-terminal-emulator"

ghost commented 2 years ago

I ran it, and it says no terminal detected, I'm assuming some bug in the code doesn't start a terminal at all, as nothing pops up.

theofficialgman commented 2 years ago

@tedmakesstuff paste the actual output please copy paste it here. don't just paraphrase

ghost commented 2 years ago

I also ran this, image (i didnt see the comment above,) and this image

theofficialgman commented 2 years ago

@tedmakesstuff run these

which gnome-terminal
which gnome-terminal.wrapper
ghost commented 2 years ago

@theofficialgman ok, here's the output image edit: btw I'm using LXTerminal (which I'm pretty sure is the terminal that comes with the pi)

theofficialgman commented 2 years ago

@theofficialgman ok, here's the output image edit: btw I'm using LXTerminal (which I'm pretty sure is the terminal that comes with the pi)

doesn't matter. your default terminal is gnome-terminal.wrapper as indicated by x-terminal-emulator

run this:

gnome-terminal -x bash -c "echo 'this a test'; sleep 10"

does a terminal window popup with "this is a test"?

ghost commented 2 years ago

okay now I see. that terminal is broken, when pi apps tries to access it, it shows the same garbage that it showed when I ran that. image and a thing to note: my system & KDE Plasma is in Greek, so that changes terminal outputs a bit.

theofficialgman commented 2 years ago

set it to english temporarily for me and run it again

export LANG="en_US.UTF-8"
export LANGUAGE="en_US.UTF-8"
export LC_ALL="en_US.UTF-8"
gnome-terminal -x bash -c "echo 'this a test'; sleep 10"

this isn't a pi-apps issue btw.. it appears that your gnome-terminal (your default selected terminal emulator) is broken or missing something

ghost commented 2 years ago

okay, will do, also im pretty sure gnome terminal DOESN'T exist.. i think its supposed to be a folder, but i went to /usr/bin and found nothing

ghost commented 2 years ago

i think i just need to change my default terminal edit: problem is, i dont know a lot about linux and i dont know how to do that either

theofficialgman commented 2 years ago

no it looks like it exists

ls -l /usr/bin/gnome-terminal
ghost commented 2 years ago

set it to english temporarily for me and run it again

export LANG="en_US.UTF-8"
export LANGUAGE="en_US.UTF-8"
export LC_ALL="en_US.UTF-8"
gnome-terminal -x bash -c "echo 'this a test'; sleep 10"

this isn't a pi-apps issue btw.. it appears that your gnome-terminal (your default selected terminal emulator) is broken or missing something

im new to linux, but i dont understand why they are called "Terminal Emulators" and not just "Terminal"

ghost commented 2 years ago

image btw that translates to: Feburary 18th 2021

theofficialgman commented 2 years ago

I still need you to run this: https://github.com/Botspot/pi-apps/issues/1970#issuecomment-1158002506

it should output in English after doing so

ghost commented 2 years ago

I changed it through raspberry pi's menu. Now it makes a lot more sense, I'm assuming the Terminal wasn't property translated (at least the errors) image

ghost commented 2 years ago

i ran pi-apps (and attempted to install an app) image if that helps, should i restart after changing the locale?

ghost commented 2 years ago

image uhh... (plasma still is in greek)

theofficialgman commented 2 years ago

forums on the internet indicate that gnome terminal doesn't do well with non-UTF-8 locales in general and will cause it to crash on launch with the error you indicated...

if you want to keep using greek, I would suggest that you just remove gnome-terminal so that your default terminal falls back to some other app (like lxterminal)

sudo apt remove gnome-terminal

make sure this isn't removing a ton of other program before continuing

ghost commented 2 years ago

I don't know if any programs rely on gnome-terminal

theofficialgman commented 2 years ago

when you go to uninstall (with the apt remove command I said), you will see a list of programs that get uninstalled alongside it

ghost commented 2 years ago

image is this what it should output?

theofficialgman commented 2 years ago

yeah you uninstalled it, thats fine. now konsole is your default x-terminal-emulator. see it has been changed to that in the log

you can start up pi-apps normally now, it probably works

ghost commented 2 years ago

works, it fell back to Konsole (which has rendering issues)

ghost commented 2 years ago

btw, i will if i need to make a new issue, but why doesn't Minecraft pi edition modded not install? it says it cant write to /home/pi/.local/bin

theofficialgman commented 2 years ago

you can always manually set the terminal emulator

sudo update-alternatives --config x-terminal-emulator

but rendering issue are outside of pi-apps control. I assuming you mean there are graphical issues

ghost commented 2 years ago

@theofficialgman well what i meant is, when i press space it adds invis chars and makes the cursor go farther each time

theofficialgman commented 2 years ago

btw, i will if i need to make a new issue, but why doesn't Minecraft pi edition modded not install? it says it cant write to /home/pi/.local/bin

a previous bug with PiKiss messed up permissions for users /home/pi/.local folder and made it root owned (which it should not be)

ghost commented 2 years ago

how come i can access it then?

theofficialgman commented 2 years ago

@theofficialgman well what i meant is, when i press space it adds invis chars and makes the cursor go farther each time

😆 thats literally what is supposed to happen.... have you never used a terminal or text editor before?

ghost commented 2 years ago

image

u cant see it but, even though the cursor is there, if i type it wont type it there,

ghost commented 2 years ago

well, since pi apps is fixed, I'm closing the issue. thank you for helping me fix it.

theofficialgman commented 2 years ago

image

u cant see it but, even though the cursor is there, if i type it wont type it there,

ah I understand now... probably something to report to the piOS devs, or KDE devs nothing you can do about it as a user.

how come i can access it then?

its all root owned, you can read it, but not write it https://github.com/Jai-JAP/pikiss-gui/issues/3

we can't automatically fix this issue since changing permissions has the potential to break other applications what are the contents of your folder:

ls -R ~/.local/

(if you have a lot of programs installed... this could be very long)

ghost commented 2 years ago

it has bin, lib and share

theofficialgman commented 2 years ago

run the actual command and send the output

ghost commented 2 years ago

well i had made a game that used love2d, so it wrote there on the share folder the high score

ghost commented 2 years ago

its probably 5 million lines long, so i wont send the output. so long that after a certain point i can't scroll back

theofficialgman commented 2 years ago

great... so pikiss messed up all of it then...

ls -l ~/.local/*

is all of this root root owned? I'm just assessing the damage this as well:

ls -l ~/.local
ghost commented 2 years ago

I'm assuming not... if so then something is wrong with my pi. my game actually saved a new high score (which is why i took long to respond)

ghost commented 2 years ago

I JUST REALIZD WHATEVER PI APPS IS INSTALLING, ITS COMPILING STUFF SO IL RESPOND IN A BIT WHEN IT FNISHES

theofficialgman commented 2 years ago

don't assume, send the results. the above commands output is much smaller

ghost commented 2 years ago

things still compiling everything BUT pikiss is root root, else is pi pi image

ghost commented 2 years ago

the bin folder says theres a pikiss-gui file, with root as owner image