search

Botspot / pi-apps

Raspberry Pi App Store for Open Source Projects
GNU General Public License v3.0
1.96k stars 202 forks source link

Install button broken #1970

Closed ghost closed 2 years ago

ghost commented 2 years ago

Confirmations

What happened?

Install button doesn't work

Description

If I press the install button on ANY app, it wont work.

What is your operating system?

Raspberry Pi OS Bullseye armhf with KDE Plasma

(Optional) Error log? Terminal output? Debug messages?

No response

Edit: for people having the same issue, try changing your default terminal, look below for further information

ghost commented 2 years ago

image

theofficialgman commented 2 years ago

share this result. the files inside the bin folder themselves look fine

ls -l ~/.local
ghost commented 2 years ago

image this says what i just said.

theofficialgman commented 2 years ago

ah there we go, so just the bin folder itself is messed up easy fix without messing anything up

sudo chown $USER:$USER ~/.local/bin
ghost commented 2 years ago

thank you! i ran the command again and it says pi pi now.

ghost commented 2 years ago

i mean because of te problem i did go and grab an appimage for the mod, but having it from pi apps makes it better.

theofficialgman commented 2 years ago

ah there we go, so just the bin folder itself is messed up easy fix without messing anything up

sudo chown $USER:$USER ~/.local/bin

@Botspot looks like the pikiss error might have only caused the bin folder itself to be root owned, not the files in ~/.local/bin which is good. its perfectly safe to run this and change it back to the user ownership with a runonce

ghost commented 2 years ago

i mean that 1 pi kiss gui file, was root ownerd

ghost commented 2 years ago

ok now i cant open pi apps, it says i dont have permissions to do so

ghost commented 2 years ago

ok i am able to launch it from terminal

theofficialgman commented 2 years ago

ok now i cant open pi apps, it says i dont have permissions to do so

wdym? we didn't change anything to do with launching pi-apps

ghost commented 2 years ago

looking at the terminal, it makes sense why it wouldn't install, it tries to put an appimage to .local/bin/ also @theofficialgman its most likely to do with plasma, as i am able to run it from the terminal.

theofficialgman commented 2 years ago

i mean that 1 pi kiss gui file, was root ownerd

yeah it shouldn't be either probably... but I'll leave that to pikiss to clean up

theofficialgman commented 2 years ago

looking at the terminal, it makes sense why it wouldn't install, it tries to put an appimage to .local/bin/ also @theofficialgman its most likely to do with plasma, as i am able to run it from the terminal.

doubtful, how are you launching it? via the icon on your desktop (if there is one) or via the apps list?

ghost commented 2 years ago

both are broken. the desktop broke long before the app list though.

theofficialgman commented 2 years ago

what is the error when clicking on them? screenshot

ghost commented 2 years ago

its a notification in greek image

ghost commented 2 years ago

translation: Launching Pi Apps (Failed) You don't have the run permissions for this file.

(basically, i dont think english plasma says that)

theofficialgman commented 2 years ago 
ls -l $HOME/.local/share/applications/pi-apps.desktop
ls -l $HOME/Desktop/pi-apps.desktop
ghost commented 2 years ago

it says that doesn't exist

theofficialgman commented 2 years ago

for which one? those are the locations of the .desktop files which correspond to the pi-apps icons

ghost commented 2 years ago

i made a shortcut, btw theres no icon in the shortcut, or a name. image

ghost commented 2 years ago

btw that was the 2nd command image

theofficialgman commented 2 years ago

I would say you probably broke the shortcut not pi-apps

just delete them and re-run the install command. it will skip installation but fix the icons

rm -f $HOME/.local/share/applications/pi-apps.desktop $HOME/Desktop/pi-apps.desktop
wget -qO- https://raw.githubusercontent.com/Botspot/pi-apps/master/install | bash
ghost commented 2 years ago

the desktop shortcut still doesn't work, but i dont really care, though the app list icon is fixed.

ghost commented 2 years ago

image what the actual truck.. it says i dont have permissions for trash the icon dissapeared so its ok i guess

theofficialgman commented 2 years ago

future users will now see a dialog prompt telling them that terminal-run has encountered a fatal error https://github.com/Botspot/pi-apps/commit/2ba6fcaded6ddc255f8c9e9cc6a94a581e71b4e4 in addition to getting this in the hidden terminal log https://github.com/Botspot/pi-apps/issues/1970#issuecomment-1155100073

no other users will be left wondering why the install/uninstall buttons don't work if their terminal is broken

Botspot commented 2 years ago

@Botspot looks like the pikiss error might have only caused the bin folder itself to be root owned, not the files in ~/.local/bin which is good. its perfectly safe to run this and change it back to the user ownership with a runonce

Done.