Cyfrin 2023-07-escrow issues

Cyfrin / 2023-07-escrow

17 stars 12 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Escalation: No zero address check for arbiter in Escrow contract's constructor

#879 dappconsulting closed 10 months ago
1
Seller may receive the wrong amount

#878 codehawks-bot closed 10 months ago
1
Seller can increase the successful amount of confirmed Escrow

#877 codehawks-bot closed 11 months ago
1
`i_price` should be used over `i_tokenContract.balanceOf(address(this)`

#876 codehawks-bot closed 10 months ago
1
Arbiter cannot be added if one wasnt added at the time of the contract creation, or if the arbiter suddenly disappears

#875 codehawks-bot closed 10 months ago
1
Any residual funds after all the transactions get stuck in the contract

#874 codehawks-bot closed 10 months ago
1
The Escrow contract can be initialized with the same buyer, seller and arbiter.

#873 codehawks-bot opened 11 months ago
0
Escrow Business Logic Error.

#872 codehawks-bot closed 10 months ago
0
Unnecessary global state read in ```Escrow.confirmReciept()```

#871 codehawks-bot closed 10 months ago
1
Address of seller and arbiter could be invalid

#870 codehawks-bot closed 10 months ago
1
Receipt can't be confirmed if seller is blacklisted by the asset

#869 codehawks-bot opened 11 months ago
0
Not creating a new excrow contract with Enough funds

#868 codehawks-bot closed 10 months ago
0
Price invariants may break with negative rebasing tokena

#867 codehawks-bot opened 11 months ago
0
Use `bytes.concat()` on bytes instead of `abi.encodePacked()` for clearer semantic meaning

#866 codehawks-bot closed 10 months ago
1
Use assembly to check for `address(0)`

#865 codehawks-bot opened 11 months ago
0
Custom error has no parameters

#864 codehawks-bot closed 10 months ago
1
Reduce gas usage by moving to Solidity 0.8.19 or later

#863 codehawks-bot closed 10 months ago
1
Front-Running Combined with Malicious Replacement Contract

#862 codehawks-bot closed 11 months ago
0
Constants in comparisons should appear on the left side

#861 codehawks-bot opened 11 months ago
0
Events are missing sender information

#860 codehawks-bot closed 10 months ago
1
NatSpec `@param` is missing

#859 codehawks-bot opened 11 months ago
0
The `nonReentrant` `modifier` should occur before all other modifiers

#858 codehawks-bot opened 11 months ago
0
Re-org attack in factory

#857 codehawks-bot closed 10 months ago
1
NatSpec `@return` argument is missing

#856 codehawks-bot opened 11 months ago
0
Effect of Zero Arbiter fees

#855 codehawks-bot closed 10 months ago
1
Not using Proxy pattern

#854 codehawks-bot opened 11 months ago
1
Potential Design Issue with `buyerAward`

#853 codehawks-bot closed 10 months ago
1
Malicious seller can grief buyer by using a USDC blacklisted address

#852 codehawks-bot opened 11 months ago
0
Incompatible with some deflationary token

#851 codehawks-bot opened 11 months ago
0
Aribiter fee can be set to 0, causing no incentive for arbiter to resolve dispute

#850 codehawks-bot closed 10 months ago
1
It is possible to front-run and steal funds from Escrow

#849 codehawks-bot closed 11 months ago
0
Need to check for zero value tranfer of ERC20 tokens.

#848 codehawks-bot opened 11 months ago
1
Unnecessary Checks in Escrow Constructor

#847 codehawks-bot closed 10 months ago
1
Preventing Fund Lockup: Ensuring a Valid Arbiter in the Escrow Contract Constructor

#846 codehawks-bot opened 11 months ago
1
Ensuring Fair Dispute Resolution: Modifying resolveDispute for Automated Award Calculation and Recipient Flexibility

#845 codehawks-bot closed 10 months ago
0
Lack of Input Validation - Buyer Award

#844 codehawks-bot closed 10 months ago
1
Lack of Input Validation - Price Parameter

#843 codehawks-bot opened 11 months ago
2
Lack of Input Validation - Arbiter Addresses

#842 codehawks-bot opened 11 months ago
1
No zero address check for arbiter in Escrow contract's constructor

#841 codehawks-bot closed 10 months ago
4
ERC20 Contract Validation Missing: Ensuring Contract Compliance in the Escrow Contract"

#840 codehawks-bot closed 11 months ago
1
if (tokenContract.balanceOf(address(this)) < price) revert Escrow__MustDeployWithTokenBalance();

#839 codehawks-bot opened 11 months ago
3
Informational suggestions

#838 codehawks-bot opened 11 months ago
1
Contracts can be created before execution and the Attacker can make a signer gate creation fail

#837 codehawks-bot closed 10 months ago
0
constructor can be payable

#836 codehawks-bot closed 10 months ago
1
Due to lack of the input validation to check whether or not `buyer != arbiter`, which allow a malicious buyer to be able to control the resolution of the dispute

#835 codehawks-bot opened 11 months ago
0
Buyer funds will stuck in contract

#834 codehawks-bot opened 11 months ago
0
Agreement on `resolveDispute` was not obtained from buyer and seller

#833 codehawks-bot closed 10 months ago
0
Buyer or Seller and arbiter can be set to the same address

#832 codehawks-bot opened 11 months ago
0
deployement will fail for fee on transfer tokens

#831 codehawks-bot opened 11 months ago
0
The buyer of the Escrow contract can obtain all tokens contract balance

#830 codehawks-bot opened 11 months ago
0