code-423n4 2021-05-fairside-findings issues

code-423n4 / 2021-05-fairside-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Incorrect type conversion in the contract `ABC` makes users unable to burn FSD tokens

#78 code423n4 closed 3 years ago
1
Incorrect type conversion in the contract `ABC` makes users unable to burn FSD tokens

#77 code423n4 opened 3 years ago
1
Flash minting and burning can reduce the paid fees when purchasing a membership or opening a cost share request

#76 code423n4 opened 3 years ago
4
The variable `fShareRatio` is vulnerable to manipulation by flash minting and burning

#75 code423n4 opened 3 years ago
3
Users are charged twice the FDT tokens when tokenizing their convictions

#74 code423n4 closed 3 years ago
3
Incorrect implementation of arctan in the contract `FairSideFormula`

#73 code423n4 opened 3 years ago
1
`pendingWithdrawals` not decreased after a `withdraw`

#72 code423n4 opened 3 years ago
2
Gas optimization for the `rootPows` function in `FairSideFormula`

#71 code423n4 opened 3 years ago
3
Should check return data from Chainlink aggregators

#70 code423n4 opened 3 years ago
2
Events in `FairSideDAO` are not indexed

#69 code423n4 opened 3 years ago
2
Wrong function called in `addRegistrationTributeGovernance`

#68 code423n4 closed 3 years ago
1
Solidity keyword `transfer` is used in the contract `Withdrawable`

#67 code423n4 opened 3 years ago
2
Unlock pragma used in multiple contracts

#66 code423n4 closed 3 years ago
2
Magic number is used multiple times in the contracts `FSDNetwork` and `ABC`

#65 code423n4 closed 3 years ago
3
Revert messages are wrong

#64 code423n4 opened 3 years ago
1
The function liquidateDai() fails

#63 code423n4 closed 3 years ago
2
Chainlink Price data could be stale

#62 code423n4 closed 3 years ago
1
convictionless mapping is not used

#61 code423n4 opened 3 years ago
2
lack of input validation of id in getConvictionScore(){}

#60 code423n4 opened 3 years ago
2
Check if variables are initialized

#59 code423n4 opened 3 years ago
2
Eth may get stuck in contract

#58 code423n4 closed 3 years ago
1
Gas optimizations - Use external instead of public

#57 code423n4 opened 3 years ago
1
Missing verification of zero address

#56 code423n4 closed 3 years ago
2
Gas optimizations - Reduce reads in purchaseMembership method

#55 code423n4 opened 3 years ago
1
Gas optimizations - checkpoints from ERC20ConvictionScore

#54 code423n4 opened 3 years ago
1
Gas optimizations - Use storage instead of memory

#53 code423n4 closed 3 years ago
2
Missing SafeMath

#52 code423n4 closed 3 years ago
2
Underflow in `FSD.burn` breaks withdrawals and could allow stealing reserve

#51 code423n4 closed 3 years ago
2
`_calculateDeltaOfFSD` fails when called with negative `_reserveDelta`

#50 code423n4 closed 3 years ago
1
ChainLink price data could be stale

#49 code423n4 closed 3 years ago
2
`Withdrawable.withdraw` does not decrease `pendingWithdrawals`

#48 code423n4 closed 3 years ago
1
Usage of transfer

#47 code423n4 closed 3 years ago
1
`TributeAccrual` missing out-of-bounds checks

#46 code423n4 closed 3 years ago
2
`ERC20ConvictionScore.acquireConviction` implements wrong governance checks

#45 code423n4 opened 3 years ago
2
`ERC20ConvictionScore.tokenizeConviction` transfers locked balance from user twice

#44 code423n4 closed 3 years ago
2
`ERC20ConvictionScore.tokenizeConviction` does not update total conviction & governance score

#43 code423n4 closed 3 years ago
1
`ERC20ConvictionScore` allows transfers to special TOTAL_GOVERNANCE_SCORE address

#42 code423n4 opened 3 years ago
3
`ERC20ConvictionScore._updateConvictionScore` uses stale credit score for `governanceDelta`

#41 code423n4 opened 3 years ago
4
`ERC20ConvictionScore`'s `governanceDelta` should be subtracted when user is not a governor anymore

#40 code423n4 opened 3 years ago
1
Changing `ERC20ConvictionScore.governanceThreshold` leads to temporarily broken state

#39 code423n4 closed 3 years ago
2
pendingWithdrawals just increments

#38 code423n4 closed 3 years ago
1
`validateVoteHash` does not confirm the vote result

#37 code423n4 opened 3 years ago
2
Wrong error message in `__castOffchainVotes`

#36 code423n4 opened 3 years ago
3
Proposals might never reach quorum because of the voting threshold

#35 code423n4 closed 3 years ago
2
`FairSideDAO.SECS_PER_BLOCK` is inaccurate

#34 code423n4 opened 3 years ago
2
Missing parameter validation

#33 code423n4 closed 3 years ago
1
Bug inside ABDKMathQuad library

#32 code423n4 opened 3 years ago
1
NFTs can never be redeemed back to their conviction scores leading to lock/loss of funds 

#31 code423n4 opened 3 years ago
3
Locked funds from tokenization are credited twice to user leading to protocol fund loss

#30 code423n4 opened 3 years ago
3
Locked funds are debited twice from user during tokenization leading to fund loss

#29 code423n4 opened 3 years ago
1