issues
search
code-423n4
/
2021-06-gro-findings
0
stars
1
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
index check should use AND condition, not OR
#76
code423n4
closed
3 years ago
2
hardcoded numbers
#75
code423n4
closed
3 years ago
2
updateStrategiesDebtRatio function and LogNewDebtRatios event
#74
code423n4
opened
3 years ago
1
typo in revert message
#73
code423n4
closed
3 years ago
2
cached version of ctrl in WithdrawHandler
#72
code423n4
closed
3 years ago
2
Unused code
#71
code423n4
opened
3 years ago
1
pDefi
#70
code423n4
closed
3 years ago
1
Incorrect use of operator leads to arbitrary minting of GVT tokens
#69
code423n4
opened
3 years ago
0
Return value of Curve APIs are ignored
#68
code423n4
closed
3 years ago
2
Stricter than needed inequalities may affect borderline scenarios
#67
code423n4
opened
3 years ago
1
Unauthorized rebalanceTrigger calls may allow one to exploit arbitrage opportunity and put system at risk
#66
code423n4
opened
3 years ago
2
Use of uninitialized value and unclear/unused logic
#65
code423n4
opened
3 years ago
0
Use of deprecated Chainlink API
#64
code423n4
closed
3 years ago
2
Unused declaration may be an indication of missing logic
#63
code423n4
closed
3 years ago
2
Big fish check ignores fee for classification during withdrawals
#62
code423n4
closed
3 years ago
2
Missing zero-address checks in constructors
#61
code423n4
closed
3 years ago
2
Whitelist addition/removal is done unconditionally
#60
code423n4
opened
3 years ago
2
Vault assets can be migrated to an arbitrary address at anytime by owner
#59
code423n4
opened
3 years ago
2
Incorrect error strings used may cause confusion
#58
code423n4
opened
3 years ago
2
Emergency disabling can only be done one stablecoin at a time
#57
code423n4
opened
3 years ago
2
Critical protocol parameter configuration/changes should have sanity/threshold checks
#56
code423n4
opened
3 years ago
2
Critical protocol parameter changes should have time-delayed enforcement
#55
code423n4
opened
3 years ago
2
Enabling preventSmartContracts may lead to lock/loss of funds
#54
code423n4
opened
3 years ago
2
The use of tx.origin for smart contract safe list is risky and not generic
#53
code423n4
opened
3 years ago
1
Flash loan risk mitigation is optional and not robust enough
#52
code423n4
opened
3 years ago
2
Safe addresses can only be added but not removed
#51
code423n4
opened
3 years ago
2
Uninitialized vaults/addresses will lead to reverts
#50
code423n4
opened
3 years ago
1
Missing zero-address check and event parameter for _emergencyHandler
#49
code423n4
opened
3 years ago
2
Having only owner unpause/restart is risky
#48
code423n4
opened
3 years ago
1
Missing emits for declared events
#47
code423n4
opened
3 years ago
0
Single-step process for critical ownership transfer is risky
#46
code423n4
opened
3 years ago
2
Missing input validation on _feeToken in DepositHandler constructor and setFeeToken()
#45
code423n4
opened
3 years ago
2
Simpler logic can save gas
#44
code423n4
opened
3 years ago
0
Removing unnecessary lpToken.balanceOf can save 4700+ gas
#43
code423n4
opened
3 years ago
0
Removing redundant code can save gas
#42
code423n4
opened
3 years ago
0
Removing unused return values can save gas
#41
code423n4
opened
3 years ago
0
Unnecessary copying of memory variables can save gas
#40
code423n4
closed
3 years ago
2
Removing unnecessary length check for static array can save gas
#39
code423n4
closed
3 years ago
2
Removing unnecessary check can save gas in withdraw flow
#38
code423n4
opened
3 years ago
0
Changing function visibility from public to external/internal/private can save gas
#37
code423n4
opened
3 years ago
0
Moving logic to where required will save >=6800 gas on deposit/withdraw flows
#36
code423n4
opened
3 years ago
0
Unnecessary zero-address check
#35
code423n4
opened
3 years ago
0
Removing unnecessary initializations can save gas
#34
code423n4
opened
3 years ago
1
Rearranging order of state variable declarations to pack them will save storage slots and gas
#33
code423n4
opened
3 years ago
0
Simplifying logic will save at least 4200-11,500 gas in deposit flow
#32
code423n4
opened
3 years ago
0
Caching repeatedly read state variables in local variables can save gas
#31
code423n4
opened
3 years ago
0
Using access lists can save gas due to EIP-2930 post-Berlin hard fork
#30
code423n4
opened
3 years ago
0
Avoid use of state variables in event emissions to save gas
#29
code423n4
opened
3 years ago
1
Upgrading the solc compiler to >=0.8 may save gas
#28
code423n4
opened
3 years ago
1
Unnecessary duplication of array
#27
code423n4
opened
3 years ago
0
Previous
Next