code-423n4 2021-07-pooltogether-findings issues

code-423n4 / 2021-07-pooltogether-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

ambiguous transferFrom

#84 code423n4 closed 3 years ago
1
redeemToken do not provide error message on insufficient imbalance

#83 code423n4 closed 3 years ago
2
event `Sponsored` is not used

#82 code423n4 closed 3 years ago
1
getBalance() uses SafeMath with Solidity 0.8.2

#81 code423n4 closed 3 years ago
2
cache duplicate call

#80 code423n4 closed 3 years ago
1
Possible enhancements to supply/redeem full balance

#79 code423n4 opened 3 years ago
3
redeemToken sends tokens with safeTransferFrom

#78 code423n4 closed 3 years ago
2
Inverted isInvalidYieldSource

#77 code423n4 closed 3 years ago
1
_requireYieldSource when setting new yield source

#76 code423n4 closed 3 years ago
1
Usage of safeApprove

#75 code423n4 closed 3 years ago
1
Validation

#74 code423n4 opened 3 years ago
3
Retrieve stuck tokens from MStableYieldSource

#73 code423n4 opened 3 years ago
2
approveMax in the constructor

#72 code423n4 opened 3 years ago
3
Small issues with events

#71 code423n4 closed 3 years ago
1
Functions that can be made external

#70 code423n4 closed 3 years ago
1
Incorrect comment about memory

#69 code423n4 opened 3 years ago
1
[Optimization] Shorten revert strings larger than 32 bytes

#68 code423n4 closed 3 years ago
3
[Optimization] Replacing low level call with a proper call

#67 code423n4 closed 3 years ago
2
[Optimization] Replace an external call with the immutable variable

#66 code423n4 closed 3 years ago
1
[Optimization] Use 0.8.4 in MStableYieldSource.sol

#65 code423n4 opened 3 years ago
1
Gas: swapYieldSource

#64 code423n4 opened 3 years ago
1
Cache deposit token

#63 code423n4 closed 3 years ago
1
`_setYieldSource` does not reset approval

#62 code423n4 closed 3 years ago
1
`redeemToken` can fail for certain tokens

#61 code423n4 opened 3 years ago
3
`_requireYieldSource` does not check return value

#60 code423n4 opened 3 years ago
3
freeze does not do anything

#59 code423n4 closed 3 years ago
1
Deposits don't work with fee-on transfer tokens

#58 code423n4 closed 3 years ago
1
Usage of deprecated safeApprove

#57 code423n4 closed 3 years ago
1
`Sponsored` event not used

#56 code423n4 closed 3 years ago
1
Declaring functions as `external` to save gas

#55 code423n4 opened 3 years ago
1
Gas optimization on `approveMax` of `MStableYieldSource`

#54 code423n4 closed 3 years ago
1
Use `abi.encodePacked` for gas optimization

#53 code423n4 opened 3 years ago
1
Inconsistent balance when supplying transfer-on-fee or deflationary tokens

#52 code423n4 opened 3 years ago
1
Yield sources cannot be swapped back

#51 code423n4 opened 3 years ago
1
The `approveMax` function of `MStableYieldSource` always reverts

#50 code423n4 closed 3 years ago
1
Missing `sponsor` function in `MStableYieldSource`

#49 code423n4 closed 3 years ago
1
Incorrect parameter of `FundsTransferred` event

#48 code423n4 closed 3 years ago
1
Use of safeApprove will always cause approveMax to revert

#47 code423n4 opened 3 years ago
1
Overly permissive access control lets anyone approve max amount

#46 code423n4 opened 3 years ago
1
Missing emit indicates missing logic for sponsor

#45 code423n4 closed 3 years ago
1
onlyOwner for approveMaxAmount() is risky

#44 code423n4 opened 3 years ago
3
Incorrect address check in transferERC20 can allow rugging

#43 code423n4 closed 3 years ago
3
Missing check for same deposit token in transferFunds()

#42 code423n4 closed 3 years ago
1
Missing zero-address checks

#41 code423n4 opened 3 years ago
1
Single-step process for critical ownership transfer/renounce is risky

#40 code423n4 opened 3 years ago
3
Initialization function can be front-run with malicious values

#39 code423n4 opened 3 years ago
3
Unnecessary mock initializer

#38 code423n4 closed 3 years ago
2
Adding unchecked directive can save gas

#37 code423n4 opened 3 years ago
1
Unnecessary external call instead of using immutable contract variable

#36 code423n4 closed 3 years ago
1
Caching the result of an external call can save 2600 gas

#35 code423n4 closed 3 years ago
1