code-423n4 2021-07-pooltogether-findings issues

code-423n4 / 2021-07-pooltogether-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Checking for zero amounts can avoid unnecessary further execution flow

#34 code423n4 closed 3 years ago
2
Redundant zero-address check

#33 code423n4 opened 3 years ago
1
Changing function visibility from public to external can save gas

#32 code423n4 opened 3 years ago
1
SwappableYieldSource: setYieldSource() should check no deposited tokens in current yield source

#31 code423n4 opened 3 years ago
1
SwappableYieldSource: Set zero allowance to current yield source when setting a new one

#30 code423n4 closed 3 years ago
1
SwappableYieldSource: Missing same deposit token check in transferFunds()

#29 code423n4 opened 3 years ago
2
SwappableYieldSource.sol: Wrong reporting amount in FundsTransferred() event

#28 code423n4 opened 3 years ago
1
SwappableYieldSource.sol: Shorten revert messages

#27 code423n4 opened 3 years ago
1
SwappableYieldSource.sol: Save depositToken as a storage variable

#26 code423n4 opened 3 years ago
1
SwappableYieldSource.sol: redeemToken() should use safeTransfer instead of safeTransferFrom

#25 code423n4 closed 3 years ago
2
SwappableYieldSource.sol: isInvalidYieldSource → isValidYieldSource

#24 code423n4 closed 3 years ago
1
SwappableYieldSource.sol: depositToken() visibility can be made external

#23 code423n4 closed 3 years ago
1
MStableYieldSource.sol: Redundant Sponsored Event

#22 code423n4 closed 3 years ago
1
MStableYieldSource.sol: Optimise balanceOf()

#21 code423n4 opened 3 years ago
1
MStableYieldSource.sol: approveMax() and depositToken() can be made external

#20 code423n4 closed 3 years ago
1
MStableYieldSource.sol: approveMax can use mAsset instead of savings.underlying()

#19 code423n4 opened 3 years ago
1
Increase Solc Optimiser Runs

#18 code423n4 opened 3 years ago
3
Lack of zero address validation in _requireDifferentYieldSource()

#17 code423n4 opened 3 years ago
1
Amount should > 0 in supplyToken() and RedeemToken() in SwappableYieldSource.sol

#16 code423n4 opened 3 years ago
2
No input validation for while setting up value for immutable state variables

#15 code423n4 opened 3 years ago
1
onlyOwnerOrAssetManager can swap Yield Source in SwappableYieldSource at any time, immediately rugging all funds from old yield source

#14 code423n4 opened 3 years ago
3
SwappableYieldSource. _setYieldSource is not removing approval for the old Yield Source

#13 code423n4 closed 3 years ago
1
SwappableYieldSource - Minor Refactoring - Use `depositToken()` instead of `yieldSource.depositToken()`

#12 code423n4 closed 3 years ago
1
SwappableYieldSource._requireYieldSource is not a guarantee that you are interacting with a valid yield source

#11 code423n4 opened 3 years ago
3
[MStableYieldSource.sol] Public functions that should be declared as external to save gas

#10 code423n4 opened 3 years ago
1
supplyTokenTo doesn't account for safeTransferFrom fees

#9 code423n4 closed 3 years ago
2
Variable name or isInvalidYieldSource is confusion

#8 code423n4 opened 3 years ago
1
_requireYieldSource not always called

#7 code423n4 opened 3 years ago
3
yield source token can be transferred by owner/assetmanager

#6 code423n4 opened 3 years ago
1
reputation risk via upgradable contracts

#5 code423n4 closed 3 years ago
2
setYieldSource leads to temporary wrong results

#4 code423n4 opened 3 years ago
1
Old yield source still has infinite approval

#3 code423n4 opened 3 years ago
1
Some tokens do not have decimals.

#2 code423n4 opened 3 years ago
1
Sponsored event not used

#1 code423n4 opened 3 years ago
3