code-423n4 2021-08-realitycards-findings issues

code-423n4 / 2021-08-realitycards-findings

1 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

UberOwner has too much power

#74 code423n4 opened 3 years ago
3
Owner has a rugpull function

#73 code423n4 closed 3 years ago
3
Gas optimization in RCMarket.sol and other files

#72 code423n4 opened 3 years ago
2
User can deposit more than maxContractBalance

#71 code423n4 opened 3 years ago
2
Wrong safeCast implementation

#70 code423n4 closed 3 years ago
1
whitelist not working as inteded

#69 code423n4 closed 3 years ago
1
gas saving in `_processRentCollection`

#68 code423n4 opened 3 years ago
1
Able to Create a Market with Odd `tokenURIs` length

#67 code423n4 closed 3 years ago
1
Function `setAmicableResolution` is susceptible to front-running attacks

#66 code423n4 closed 3 years ago
2
Use `_safeTransfer` when transferring NFTs

#65 code423n4 opened 3 years ago
3
Return value of `erc20.approve` is unchecked

#64 code423n4 opened 3 years ago
3
Direct usage of `ecrecover` allows signature malleability

#63 code423n4 opened 3 years ago
2
Unable to Recover Improperly Transferred Tokens

#62 code423n4 opened 3 years ago
3
add zero address validation in constructor

#61 code423n4 opened 3 years ago
2
use of array without checking its length

#60 code423n4 opened 3 years ago
1
NFTHubs don't set `_baseUri`

#59 code423n4 closed 3 years ago
2
Deposits don't work with fee-on transfer tokens

#58 code423n4 opened 3 years ago
1
Market whitelist does not work

#57 code423n4 closed 3 years ago
1
`RCTreasury` role setup does not match diagram

#56 code423n4 closed 3 years ago
1
`RCLeaderboard.market` storage variable is not used

#55 code423n4 opened 3 years ago
2
Markets can start in the past

#54 code423n4 opened 3 years ago
3
`getMarketInfo` skipResults does not work

#53 code423n4 closed 3 years ago
2
Missing parameter validation

#52 code423n4 closed 3 years ago
2
uninitialized-state-variables

#51 code423n4 closed 3 years ago
1
No check for the referenceContractAddress in createMarket()

#50 code423n4 opened 3 years ago
1
no time restriction in setMarketTimeRestrictions()

#49 code423n4 opened 3 years ago
2
Remove hardhat console import

#48 code423n4 opened 3 years ago
1
RCTreasury: Spelling Errors

#47 code423n4 opened 3 years ago
1
RCTreasury: Missing setter for marketWhitelist mapping

#46 code423n4 closed 3 years ago
1
RCTreasury: new hasRole() function with string role

#45 code423n4 opened 3 years ago
2
RCTreasury: AccessControl diagram contains Leaderboard, but it has no role

#44 code423n4 opened 3 years ago
3
RCLeaderboard: Erroneous comment

#43 code423n4 opened 3 years ago
3
RCFactory: Unnecessary casting in updateTokenURI()

#42 code423n4 opened 3 years ago
1
RCFactory: Solve stack too deep for getMarketInfo()

#41 code423n4 opened 3 years ago
2
RCFactory: Skipping results don't work as intended in getMarketInfo()

#40 code423n4 closed 3 years ago
1
RCFactory: Do multiplication instead of division for length checks

#39 code423n4 opened 3 years ago
1
Access Control Constants

#38 code423n4 opened 3 years ago
1
Insufficient checks at the smart contract level to ensure that previous user address is the lowest bid that is higher than the bid to be added.

#37 code423n4 closed 3 years ago
2
Unclear conditional check within bidExists() function

#36 code423n4 closed 3 years ago
2
transferCard should be done after treasury is updated.

#35 code423n4 opened 3 years ago
1
bidExists check is in the wrong place.

#34 code423n4 closed 3 years ago
2
`removeFromLeaderboard()` Gas Optimization

#33 code423n4 closed 3 years ago
2
Tight Variable Packing

#32 code423n4 opened 3 years ago
3
Monopolization of the bidding platform

#31 code423n4 closed 3 years ago
2
Parameter updates not propagated

#30 code423n4 opened 3 years ago
1
one of the whitelist mechanisms doesn't work

#29 code423n4 closed 3 years ago
1
uint32 conversion doesn't work as expected.

#28 code423n4 opened 3 years ago
2
findNewOwner edgecase

#27 code423n4 opened 3 years ago
4
Improper Setup of AccessControl

#26 code423n4 closed 3 years ago
2
Divide Before Multiply

#25 code423n4 opened 3 years ago
1