code-423n4 2021-10-covalent-findings issues

code-423n4 / 2021-10-covalent-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Remove duplicate reads of validatorsN storage variable

#90 code423n4 closed 2 years ago
1
Move Function _stake Validator Declaration

#89 code423n4 opened 2 years ago
1
Change CQT storage variable to be constant

#88 code423n4 closed 2 years ago
2
Comment typos

#87 code423n4 closed 2 years ago
2
Public functions that should be external

#86 code423n4 closed 2 years ago
2
Save Gas With The Unchecked Keyword

#85 code423n4 closed 2 years ago
3
DOS By Front Running DelegatedStaking `initialize`

#84 code423n4 closed 2 years ago
2
addValidator should validate commissionRate

#83 code423n4 closed 2 years ago
2
public external functions

#82 code423n4 closed 2 years ago
2
Unchecked operations

#81 code423n4 closed 2 years ago
2
Lower than uint256 type variables

#80 code423n4 closed 2 years ago
2
Make CQT variable constant

#79 code423n4 closed 2 years ago
2
Gas Optimization on the Public Functions

#78 code423n4 closed 2 years ago
2
Validators can only be added but not removed

#77 code423n4 closed 2 years ago
2
change lines to save gas

#76 code423n4 closed 2 years ago
2
Change lines to save gas

#75 code423n4 opened 2 years ago
1
setValidatorMinStakedRequired forgot to check amount >0

#74 code423n4 closed 2 years ago
2
Change order of lines to save gas in setAllocatedTokensPerEpoch

#73 code423n4 opened 2 years ago
2
Anyone can call the initialize function

#72 code423n4 closed 2 years ago
2
Save Gas With The Unchecked Keyword

#71 code423n4 closed 2 years ago
2
Inconsistent definition of integer sizes in function `getDelegatorDetails()`

#70 code423n4 opened 2 years ago
1
Function `addValidator()` is missing check if validator exists already

#69 code423n4 closed 2 years ago
2
Unclear definition of `validatorId`'s integer size

#68 code423n4 opened 2 years ago
1
Declare variable `CQT` as constant

#67 code423n4 opened 2 years ago
1
Epoch may rounded to zero in deposit depositRewardTokens and takeOutRewardTokens

#66 code423n4 closed 2 years ago
2
Validator can fail to receive commission reward in `redeemAllRewards`

#65 code423n4 opened 2 years ago
2
Redundant Check On the Uint

#64 code423n4 closed 2 years ago
2
unnecessary assert when dealing with CQT

#63 code423n4 opened 2 years ago
2
Use constant to save gas

#62 code423n4 closed 2 years ago
2
No sanity check in `addValidator`.

#61 code423n4 closed 2 years ago
1
Misleading parameter name

#60 code423n4 opened 2 years ago
1
Unbounded iteration over validators array

#59 code423n4 opened 2 years ago
2
`addValidator` could restrict `commissionRate`

#58 code423n4 closed 2 years ago
2
`unstake` should update exchange rates first

#57 code423n4 opened 2 years ago
1
ERC20 return values not checked

#56 code423n4 closed 2 years ago
2
Code Style: private/internal function names should be prefixed with `_`

#55 code423n4 opened 2 years ago
1
Change unchanged storage variables to constants can save gas

#54 code423n4 closed 2 years ago
2
Cache storage variables in the stack can save gas

#53 code423n4 opened 2 years ago
3
Adding unchecked directive can save gas

#52 code423n4 opened 2 years ago
1
Check `validatorId < validatorsN` can be done earlier

#51 code423n4 opened 2 years ago
2
Unsafe type casting may over/underflow

#50 code423n4 closed 2 years ago
2
Avoid unnecessary storage read can save gas

#49 code423n4 opened 2 years ago
0
Avoid unnecessary code execution can save gas

#48 code423n4 closed 2 years ago
2
`setAllocatedTokensPerEpoch()` will fail when `endEpoch > block.number`

#47 code423n4 closed 2 years ago
2
Code duplication

#46 code423n4 opened 2 years ago
1
Usage of an incorrect version of `Ownbale` library can potentially malfunction all `onlyOwner` functions

#45 code423n4 opened 2 years ago
2
`redeemAllRewards()` may fail when a validator tries to redeem `v.commissionAvailableToRedeem`

#44 code423n4 closed 2 years ago
2
Changing function visibility from public to external can save gas

#43 code423n4 closed 2 years ago
2
Typos

#42 code423n4 opened 2 years ago
2
Can't change CQT

#41 code423n4 closed 2 years ago
1