issues
search
code-423n4
/
2021-11-nested-findings
1
stars
1
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
`_handleUnderSpending` reverts if condition is false
#183
code423n4
opened
2 years ago
0
Function using `msg.value` called in loop
#182
code423n4
opened
2 years ago
1
No ERC20 safe* versions called
#181
code423n4
closed
2 years ago
1
Can add duplicate operators
#180
code423n4
opened
2 years ago
0
Cannot change `tokenUri`
#179
code423n4
opened
2 years ago
2
Missing parameter validation
#178
code423n4
opened
2 years ago
0
Adding unchecked directive can save gas
#177
code423n4
closed
2 years ago
1
`FeeSplitter.sol#sendFees()` Use inline expression can save gas
#176
code423n4
closed
2 years ago
1
Cache and read storage variables from the stack can save gas
#175
code423n4
opened
2 years ago
1
`FeeSplitter.sol#setRoyaltiesWeight()` Two storage writes can be combined into one
#174
code423n4
closed
2 years ago
1
Adding unchecked directive can save gas
#173
code423n4
opened
2 years ago
1
Unsafe token transfer
#172
code423n4
closed
2 years ago
1
Cache array length in for loops can save gas
#171
code423n4
closed
2 years ago
1
`NestedFactory#removeOperator()` Avoid empty items can save gas
#170
code423n4
opened
2 years ago
3
Inconsistent use of `_msgSender()`
#169
code423n4
opened
2 years ago
2
Use of deprecated `safeApprove`
#168
code423n4
closed
2 years ago
1
Consider making `_calculateFees` inline to save gas
#167
code423n4
opened
2 years ago
2
Use of assert() instead of require()
#166
code423n4
opened
2 years ago
1
Missing events for critical operations
#165
code423n4
closed
2 years ago
1
Use short reason strings can save gas
#164
code423n4
closed
2 years ago
1
Avoid unnecessary external calls can save gas
#163
code423n4
closed
2 years ago
1
Avoid unnecessary storage writes can save gas
#162
code423n4
opened
2 years ago
1
Misleading error message
#161
code423n4
opened
2 years ago
0
`NestedFactory.sol#_submitInOrders()` Wrong implementation cause users to be overcharged
#160
code423n4
opened
2 years ago
2
`MixinOperatorResolver.sol#isResolverCached()` become malfunctioning when an `operator` is removed
#159
code423n4
closed
2 years ago
2
`removeOperator()` Wrong implementation
#158
code423n4
closed
2 years ago
2
`importOperators()` should be run atomically with `rebuildCaches()` to make sure `addressCache` is up-to-date with the new `operators`
#157
code423n4
closed
2 years ago
2
Empty files
#156
code423n4
closed
2 years ago
1
Function state mutability can be restricted to pure
#155
code423n4
closed
2 years ago
1
Unused function parameters
#154
code423n4
closed
2 years ago
3
Unused local variables
#153
code423n4
closed
2 years ago
3
`safeApprove` is deprecated
#152
code423n4
closed
2 years ago
1
Gas Optimization: Set allowance only when needed
#151
code423n4
opened
2 years ago
2
Unused balance variable in triggerForToken function
#150
code423n4
closed
2 years ago
1
Unexpected transfer can lead to DOS in `FeeSplitter`
#149
code423n4
closed
2 years ago
2
removeOperator doesn't work as expected
#148
code423n4
closed
2 years ago
2
Gas Optimization: Cache length to use in for loop
#147
code423n4
closed
2 years ago
1
Gas Optimization: Pack struct in FeeSplitter.sol
#146
code423n4
opened
2 years ago
3
Gas Optimization: Use memory instead of storage
#145
code423n4
closed
2 years ago
1
Hardcoded fee
#144
code423n4
closed
2 years ago
1
Owner of `NestedReserve` can drain all fund
#143
code423n4
closed
2 years ago
2
Unable to remove operator at index 0
#142
code423n4
closed
2 years ago
2
Duplicated entries can be added into operators array
#141
code423n4
closed
2 years ago
1
Long Revert Strings
#140
code423n4
closed
2 years ago
1
isResolverCached() will always return false after removing operator
#139
code423n4
opened
2 years ago
2
FeeSplitter: Unbounded shareholder weights can cause DOS
#138
code423n4
closed
2 years ago
2
FeeSplitter: Unbounded number of shareholders can cause DOS
#137
code423n4
opened
2 years ago
0
NestedFactory: Ensure zero msg.value if transferring from user and inputToken is not ETH
#136
code423n4
opened
2 years ago
0
FeeSplitter: No sanity check to prevent shareholder from being added twice.
#135
code423n4
opened
2 years ago
3
FeeSplitter: ETH_ADDR isn't supported
#134
code423n4
opened
2 years ago
2
Previous
Next