code-423n4 2022-06-putty-findings issues

code-423n4 / 2022-06-putty-findings

5 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

QA Report

#417 code423n4 opened 2 years ago
2
not checking TokenIds of new order against originalOrder in acceptCounter

#416 code423n4 closed 2 years ago
2
Gas Optimizations

#415 code423n4 opened 2 years ago
0
`order.maker` can arbitrarily revoke its approval to cancel its signed orders.

#414 code423n4 closed 2 years ago
5
Gas Optimizations

#413 code423n4 opened 2 years ago
0
QA Report

#412 code423n4 opened 2 years ago
0
Gas Optimizations

#411 code423n4 opened 2 years ago
0
Attacker can steal other users funds by signing malicious orders which looks profitable and tricking users (or by mistake) to call fillOrder(), the malicious order transfers PuttyV2 NFT token position of caller to attacker

#410 code423n4 closed 2 years ago
2
Gas Optimizations

#409 code423n4 opened 2 years ago
0
QA Report

#408 code423n4 opened 2 years ago
1
QA Report

#407 code423n4 opened 2 years ago
0
Maker could avoid premium on longs and strike payment on short puts by creating an order with a fake baseAsset token

#406 code423n4 closed 2 years ago
2
Users can cancel irrelevant orders which do not exist

#405 code423n4 closed 2 years ago
4
`fee` proportional to strike even for unexercised orders

#404 code423n4 closed 2 years ago
3
Gas Optimizations

#403 code423n4 opened 2 years ago
0
QA Report

#402 code423n4 opened 2 years ago
0
Gas Optimizations

#401 code423n4 closed 2 years ago
2
Airdrop malicious NFT/token

#400 code423n4 closed 2 years ago
3
QA Report

#399 code423n4 opened 2 years ago
0
Gas Optimizations

#398 code423n4 opened 2 years ago
0
Fake orders can be created for non existant tokens

#397 code423n4 closed 2 years ago
5
`cancel()` function does not check if the order already was filled at some point.

#396 code423n4 opened 2 years ago
5
Gas Optimizations

#395 code423n4 closed 2 years ago
1
Cannot create short call floorToken option

#394 code423n4 closed 2 years ago
1
QA Report

#393 code423n4 opened 2 years ago
0
Gas Optimizations

#392 code423n4 opened 2 years ago
0
Gas Optimizations

#391 code423n4 opened 2 years ago
0
QA Report

#390 code423n4 opened 2 years ago
2
Exercised call options floor asset token ids not saved to short position

#389 code423n4 closed 2 years ago
1
Native funds sent over with an order are lost when not used

#388 code423n4 closed 2 years ago
1
missing check of the non-existence of both order sides positions in fillOrder

#387 code423n4 closed 2 years ago
2
Gas Optimizations

#386 code423n4 closed 2 years ago
1
Gas Optimizations

#385 code423n4 opened 2 years ago
0
Gas Optimizations

#384 code423n4 opened 2 years ago
0
setBaseURI() and setFee() functions are payable but don't perform any logic on assets

#383 code423n4 opened 2 years ago
4
Condition check to verify the floorAssetTokenIds and order.floorTokens length can be improved for robustness.

#382 code423n4 closed 2 years ago
2
Gas Optimizations

#381 code423n4 opened 2 years ago
0
PUT short option is always in loss

#380 code423n4 closed 2 years ago
6
Gas Optimizations

#379 code423n4 opened 2 years ago
0
QA Report

#378 code423n4 opened 2 years ago
0
The contract serves as a flashloan pool without fee

#377 code423n4 opened 2 years ago
6
The fee is not paid as intended for put orders

#376 code423n4 closed 2 years ago
1
An attacker can force a flash loan and get temporary ownership of any NFT held inside putty and perform arbitrary logic with it.

#375 code423n4 closed 2 years ago
4
QA Report

#374 code423n4 opened 2 years ago
1
Zero strike call options will avoid paying system fee

#373 code423n4 opened 2 years ago
3
When ETH is sent with `fillOrder` and `exercise` functions, the ETH can be lost

#372 code423n4 closed 2 years ago
3
Create a short put order with zero tokenAmount makes the option impossible to exercise

#371 code423n4 closed 2 years ago
1
manipulation of given supply through mint functionality | There is an absence of checks for the mint functionality which can lead to undesirable effects. |

#370 code423n4 closed 2 years ago
1
Create a short call order with non empty floor makes the option impossible to exercise and withdraw

#369 code423n4 opened 2 years ago
5
Gas Optimizations

#368 code423n4 closed 2 years ago
1

Previous Next