issues
search
ghoul-sol
/
treasure-staking
10
stars
1
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Bridgeworld Harvesters contract review
#69
fulldecent
opened
2 years ago
2
Please create test case for Harvester.withdrawPosition with unstaking NFTs in the same transaction
#68
fulldecent
opened
2 years ago
0
Several test cases are not implemented
#67
fulldecent
opened
2 years ago
0
getRatePerSecond produces incorrect result on start of stream
#66
fulldecent
closed
2 years ago
2
canStake and canUnstake functions are more dangerous than their names imply
#65
fulldecent
closed
2 years ago
0
Divide-by-zero if admin performs multiple operations at once
#64
fulldecent
closed
2 years ago
1
💣 A configuration error may allow anybody to burn other's NFTs
#63
fulldecent
closed
2 years ago
0
💣 Any NFT can get stuck after _setNftConfig
#62
fulldecent
closed
2 years ago
1
💣 1/1 legions can get stuck after setInitialMetadataForLegion
#61
fulldecent
closed
2 years ago
1
💣 The liquidity pool can leak liquidity leading to a run on the bank
#60
fulldecent
closed
2 years ago
1
Rewards duration restriction is not checked
#59
fulldecent
closed
2 years ago
0
AtlasMine does not implement interface detection for super classes
#58
fulldecent
closed
2 years ago
0
Player can use disallowed locking periods
#57
fulldecent
closed
2 years ago
0
💣 Extractor boosts are not effective for their full lifetime
#56
fulldecent
closed
2 years ago
1
💣 Player stakes cannot be removed if harvester disabled
#55
fulldecent
closed
2 years ago
1
💣 Treasure boosts incorrect
#54
fulldecent
closed
2 years ago
1
💣 Legion weights matrix incorrect
#53
fulldecent
closed
2 years ago
1
💣 Legion ranks matrix incorrect
#52
fulldecent
closed
2 years ago
1
Design does not specify what happens to disabled harvesters' emissions share
#51
fulldecent
closed
2 years ago
2
Legions boost is missing boost factor
#50
fulldecent
closed
2 years ago
1
Design does not differentiate between fixed and configurable parameters
#49
fulldecent
closed
2 years ago
1
Major administrative functions with dire consequences are not listed as "emergency" functions
#48
fulldecent
closed
2 years ago
1
Conflicting requirements on timelock periodicity
#47
fulldecent
closed
2 years ago
1
Legion boost average rank is vulnerable to griefing attack
#46
fulldecent
closed
2 years ago
1
Corruption modifier specification is not specific enough
#45
fulldecent
closed
2 years ago
2
Conflicting requirements on MAGIC staking utilization multiplier
#44
fulldecent
closed
2 years ago
1
Inconsistent use of option `override` keyword for implementation of interface
#43
fulldecent
closed
2 years ago
1
HarvestFactory grants all permissions to a single account
#42
fulldecent
closed
2 years ago
1
Revert strings are disguised as revert errors
#41
fulldecent
closed
2 years ago
0
⚠️ NatSpec documentation is missing
#40
fulldecent
opened
2 years ago
0
⚠️ OpenZeppelin Contracts version is unsupported
#39
fulldecent
closed
2 years ago
0
⚠️ Solidity version is unsupported
#38
fulldecent
closed
2 years ago
0
Function isMaxUserGlobalDeposit does not calculate if it is the max
#37
fulldecent
closed
2 years ago
0
getHarvesterEmissionsShare function does not return emissions share
#36
fulldecent
closed
2 years ago
0
_vestedPrincipal function has unexpected functionality
#35
fulldecent
closed
2 years ago
0
Legion "class" and "rarity" are used without consistent meaning
#34
fulldecent
closed
2 years ago
0
"Boost" word is used inconsistently
#33
fulldecent
opened
2 years ago
0
Unnecessary use of gendered word for primary controller
#32
fulldecent
closed
2 years ago
1
Typos
#31
fulldecent
closed
2 years ago
1
Unnecessary use of regulated finance words
#30
fulldecent
closed
2 years ago
1
Add install instructions
#29
fulldecent
closed
2 years ago
0
renamed: contracts/AtlasMineV1.sol -> contracts/AtlasMine.sol
#28
ghoul-sol
closed
2 years ago
0
Delete AtlasMine.sol
#27
ghoul-sol
closed
2 years ago
0
Rename atlas mine v1
#26
ghoul-sol
closed
2 years ago
0
Fix for AtlasMine rounding bug
#25
ghoul-sol
closed
2 years ago
0
Harvesters
#24
ghoul-sol
closed
2 years ago
0
Treasure staking rules
#23
peitalin
closed
2 years ago
0
Treasures staking
#22
peitalin
closed
2 years ago
0
Parameter changes
#21
peitalin
closed
2 years ago
1
Param updates
#20
peitalin
closed
2 years ago
0
Previous
Next