-
Hi Pedro,
I would like to fix some `clippy`-warnings in the code, if this is ok for you.
Best regards,
Maximilian
-
- [ ] deny unwrap, expect, and indexing/slicing
- [ ] forbid unsafe
-
As the code has evolved some of these clippy overrides are possibly no longer needed or the code can be refactored to remove them.
-
My users have bad Galaxy habits. This is a combination of
- lack of training
- generally not putting all of the effort needed into maintaining tidy workspaces
That's normal, and I can combat the …
-
I've ran clippy on the project and it reports some issues. I think it would be nice to apply the suggestions and even ran clippy on CI/Travis.
What do you think?
-
when we run cargo clippy it will spill out a lot of warnings. we might want to tackle that as we code.
cargo clippy
cargo fmt as well.
-
candidates:
* `clippy::pedantic` which has a bunch of type cast safety checks
* [clippy::unwrap_used](https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used)
* maybe more we could …
-
We should be using a linter to help clean up the codebase. Clippy seems to be great, let's use it.
```
root@9eaaabfc2ea8:/home/test/safeposix-rust# cargo clippy
...
warning: `rustposix` (lib)…
-
On 1.81.0 stable and 1.82.0-beta.5 I get an ICE when `#[expect()]`ing various Clippy lints on a struct field. Interestingly, I could repro the ICE for `clippy::unreadable_literal`, `clippy::unusual_…
-
During the update of Rust in runtimes, many warnings about `unreachable-patterns` in `#[frame_support::pallet]` appeared, as noted in https://github.com/polkadot-fellows/runtimes/pull/473. These warni…