-
PHP Strict Standards: Only variables should be passed by reference in /home/users/klarka/wc/2/libs/shard-query/include/shard-query.php on line 2115.
What about some refactoring to support strict PHP…
vojta updated
8 years ago
-
Authorship specifies no Node requirements, and will fail if using modern NodeJS. To fix this the `package.json` should specify the range of Node versions that are supported in the `engines` section, a…
tomjn updated
2 months ago
-
#Feature Reviewed: Store Component
Implemented By: Italia
### Design Principles
- [x] Does the design follow SOLID principles?
- [x] Does the design follow OOP rules?
- [ ] Is the design simp…
-
Heyo!
A few code review comments:
- Setup `.gitignore` with nice Python default ignores so you don't push cache stuff up https://github.com/github/gitignore/blob/main/Python.gitignore
- Pull `.…
-
I sort of hate this file. We've allowed too many shenanigans in here, for far too long. It's time to modernize it a bit, bring it inline with current coding standards, like much of our admin JS.
So…
-
I like @spratt's proposal.
https://github.com/CarletonU-COMP2406-W2013/Steamed-Pears/wiki/Coding-Standards#javascript-1
The only thing I disagree with is having an asterix on the far right of the te…
-
## Toolchain
such as:
- http://www3.ntu.edu.sg/home/ehchua/programming/cpp/gcc_make.html
- http://www.csee.umbc.edu/courses/undergraduate/202/fall04/Projects/CommonErrors.shtml
- https://www.gnu.org/…
-
Can easily cause extra white space to be outputted if left in.
http://drupal.org/node/1285886#comment-5046056
-
We recommend that every repo has a code of conduct. If you don’t feel comfortable creating your own Code of Conduct from scratch we highly recommend using one of the templates provided by GitHub. If y…
-
I think it would benefit the project in case the code base followed the [PSR-2](http://www.php-fig.org/psr/psr-2/) coding style standards. Currently e.g. the following rules are violated:
- _Code M…