code-423n4 2021-06-tracer-findings issues

code-423n4 / 2021-06-tracer-findings

1 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Using deprecated Chainlink function `latestAnswer`

#145 code423n4 closed 3 years ago
1
A market's hourly average price can be biased by a large number of trades

#144 code423n4 closed 3 years ago
1
Add reentracy protections on function `executeTrade`

#143 code423n4 opened 3 years ago
5
The `currentHour` variable in `Pricing` could be out of sync

#142 code423n4 opened 3 years ago
0
Margin value is not checked to be non-negative in `leveragedNotionalValue`

#141 code423n4 opened 3 years ago
1
The `averagePriceForPeriod` function may revert without proper error message returned

#140 code423n4 opened 3 years ago
0
`Prices.averagePrice` does not show a difference between no trades and a zero price

#139 code423n4 opened 3 years ago
0
Two tracer markets can have the same market ID

#138 code423n4 closed 3 years ago
2
The `setDecimals` function of `GasOracle` is permissionless

#137 code423n4 closed 3 years ago
3
The `transferOwnership` function of `Liquidation` lacks a non-zero address check

#136 code423n4 closed 3 years ago
2
Unchangeable chain ID information in `EIP712_DOMAIN`

#135 code423n4 closed 3 years ago
1
Return values of ERC20 `transfer` and `transferFrom` are unchecked

#134 code423n4 closed 3 years ago
2
Unlocked pragma used in multiple contracts

#133 code423n4 opened 3 years ago
2
Use latestRoundData instead of latestAnswer

#132 code423n4 closed 3 years ago
2
Gas savings in verifyAndSubmitLiquidation()

#131 code423n4 opened 3 years ago
1
Missing validation on calculateTWAP

#130 code423n4 opened 3 years ago
2
Accumulation of error in method averagePriceForPeriod

#129 code423n4 closed 3 years ago
2
Change claimEscrow() to external

#128 code423n4 opened 3 years ago
0
Logic error in fee subtraction

#127 code423n4 opened 3 years ago
2
Missing validation matchOrders == true in executeTrade

#126 code423n4 closed 3 years ago
1
Gas savings in getPoolFundingRate()

#125 code423n4 opened 3 years ago
0
Comparison between Raw token amount and WAD

#124 code423n4 closed 3 years ago
2
Bots can frontrun market maker orders and cancel orders.

#123 code423n4 closed 3 years ago
3
State variable not used

#122 code423n4 opened 3 years ago
1
Superfluous verifySignature function

#121 code423n4 opened 3 years ago
0
Use EIP-1167 in order to deploy new perpetual swap contracts

#120 code423n4 opened 3 years ago
0
Wrong trading pricing calculations

#119 code423n4 opened 3 years ago
1
Unnecessary type conversions

#118 code423n4 opened 3 years ago
0
Missing checks for lowestMaxLeverage < maxLeverage and insurancePoolSwitchStage < deleveragingCliff

#117 code423n4 opened 3 years ago
0
Underflow problems occurring when a token has >18 decimals

#116 code423n4 opened 3 years ago
1
No check transferFrom() return value

#115 code423n4 opened 3 years ago
0
EIP-712 ChainId hardcoded

#114 code423n4 closed 3 years ago
1
No support for token with decimals > 18

#113 code423n4 closed 3 years ago
2
No support for token with fee on transfer

#112 code423n4 closed 3 years ago
1
erc20 transfers do not check the return value

#111 code423n4 closed 3 years ago
2
Low-level call returns true even if the account called is non-existent

#110 code423n4 closed 3 years ago
1
inclusive check that account is not above minimum margin

#109 code423n4 opened 3 years ago
0
amountToReturn > receipt.escrowedAmount could be inclusive

#108 code423n4 opened 3 years ago
0
claimEscrow with not yet existing id

#107 code423n4 closed 3 years ago
3
Wrong funding index in settle when no base?

#106 code423n4 opened 3 years ago
0
Insurance slippage reimbursement can be used to steal insurance fund

#105 code423n4 opened 3 years ago
1
Deflationary tokens are not supported

#104 code423n4 opened 3 years ago
2
Market creator can steal user funds by setting fess >= 100%

#103 code423n4 closed 3 years ago
2
Can set values to more than 100%

#102 code423n4 opened 3 years ago
0
`TracerPerpetualSwaps.LIQUIDATION_GAS_COST` should be upgradeable

#101 code423n4 closed 3 years ago
1
Trader orders can be frontrun and users can be denied from trading

#100 code423n4 opened 3 years ago
2
Wrong token approval

#99 code423n4 opened 3 years ago
2
SafetyWithdraw ERC20 return values not checked

#98 code423n4 closed 3 years ago
2
TracerPerpetualSwaps ERC20 return values not checked

#97 code423n4 closed 3 years ago
2
Insurance ERC20 return values not checked

#96 code423n4 closed 3 years ago
1