issues
search
code-423n4
/
2021-07-sherlock-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
`transferFrom` gas improval
#100
code423n4
opened
3 years ago
2
`decreaseApproval` gas improval
#99
code423n4
closed
3 years ago
1
`increaseApproval` gas improval
#98
code423n4
opened
3 years ago
0
`payout` does token transfers twice
#97
code423n4
opened
3 years ago
1
`SherX.setWeights` only accrue _tokens
#96
code423n4
opened
3 years ago
1
Check _aaveLmReceiver and _sherlock are not empty
#95
code423n4
opened
3 years ago
0
_token parameter not validated
#94
code423n4
closed
3 years ago
2
Loops may exceed gas limit
#93
code423n4
opened
3 years ago
0
getInitialUnstakeEntry when unstakeEntries is empty
#92
code423n4
opened
3 years ago
0
[AaveV2.sol] Multiple values from external functions being called are ignored
#91
code423n4
closed
3 years ago
2
[Bug] A critical bug in bps function
#90
code423n4
opened
3 years ago
0
General suggestions
#89
code423n4
opened
3 years ago
0
[Optimization] Change variable to immutable
#88
code423n4
closed
3 years ago
1
[Optimization] Changing memory to calldata and again caching in loops
#87
code423n4
opened
3 years ago
0
[Optimization] Caching in for loops
#86
code423n4
opened
3 years ago
0
[Optimization] Packing various structs carefully
#85
code423n4
opened
3 years ago
0
[Optimization] Use at least 0.8.4
#84
code423n4
opened
3 years ago
0
[Optimization] Setting higher value for optimize-runs
#83
code423n4
opened
3 years ago
0
[Optimization] A branchless version of an if else statement
#82
code423n4
opened
3 years ago
0
[Optimization] Caching variable
#81
code423n4
opened
3 years ago
0
[SherX.sol] Multiple external function values are ignored
#80
code423n4
closed
3 years ago
2
getFirstMoneyOut _token parameter
#79
code423n4
opened
3 years ago
0
withdraw returns the final amount withdrawn
#78
code423n4
opened
3 years ago
1
[Gov.sol] Ignoring the return value of function _token.approve(...)
#77
code423n4
closed
3 years ago
2
Order of fields in struct
#76
code423n4
closed
3 years ago
1
Immutable variables
#75
code423n4
closed
3 years ago
1
.length in a loop can be extracted into a variable
#74
code423n4
closed
3 years ago
1
Call to LibDiamond.contractOwner() can be cached
#73
code423n4
opened
3 years ago
0
Functions aBalance and balanceOf
#72
code423n4
opened
3 years ago
0
ps.govPool in function tokenInit
#71
code423n4
closed
3 years ago
2
Re-entrancy mitigation
#70
code423n4
opened
3 years ago
0
Group related data into separate structs
#69
code423n4
opened
3 years ago
0
Inclusive checks
#68
code423n4
opened
3 years ago
0
Approval event in LibSherXERC20
#67
code423n4
opened
3 years ago
2
Function initializeSherXERC20 can be called multiple times
#66
code423n4
closed
3 years ago
1
AaveV2 approves lending pool in the constructor
#65
code423n4
opened
3 years ago
0
transferFrom when from = to
#64
code423n4
opened
3 years ago
3
Use EnumerableSet to store protocols
#63
code423n4
opened
3 years ago
0
typo: `ineglible_yield_amount` -> `ineligible_yield_amount`
#62
code423n4
opened
3 years ago
1
[PoolBase.sol] Calculations are being divided before being multiplied
#61
code423n4
opened
3 years ago
2
Use calldata is a little more gas efficient
#60
code423n4
opened
3 years ago
0
Free stake by replacing input token address
#59
code423n4
closed
3 years ago
1
Unnecessary `_govPool == 0` check in `function tokenInit`
#58
code423n4
closed
3 years ago
2
[NativeLock.sol] Local Variables shadowing other variables
#57
code423n4
closed
3 years ago
2
[ForeignLock.sol] Local Variables Shadowing other variables
#56
code423n4
closed
3 years ago
2
[AaveV2.sol] Function that should be declared as external to save gas
#55
code423n4
closed
3 years ago
1
[LibSherX.sol] Functions that should be declared as external to save gas
#54
code423n4
closed
3 years ago
1
[LibPool.sol] Functions that should be declared as external to save gas
#53
code423n4
closed
3 years ago
1
[PoolBase.sol] Functions that are public that should be declared as external to save gas
#52
code423n4
closed
3 years ago
1
Gov.sol: Use SafeERC20.safeApprove in tokenUnload()
#51
code423n4
opened
3 years ago
0
Previous
Next