issues
search
code-423n4
/
2021-07-sherlock-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Saving gas by checking the last-recorded block number
#150
code423n4
opened
3 years ago
1
Avoid repeating storage reads in a loop to save gas
#149
code423n4
opened
3 years ago
1
Gas optimization on calculating the storage slot of a token
#148
code423n4
opened
3 years ago
0
Declare variables as `constant` or `immutable` to save gas
#147
code423n4
closed
3 years ago
1
Declare dynamic function parameters as `calldata` to save gas
#146
code423n4
closed
3 years ago
1
Possible inaccurate stake balance after withdrawing funds from strategies
#145
code423n4
closed
3 years ago
3
User's `calcUnderlyingInStoredUSD` value is underestimated
#144
code423n4
opened
3 years ago
2
Transfer-on-fee/deflationary tokens are not correctly accounted for
#143
code423n4
closed
3 years ago
1
Unsafe implementation of `decreaseApproval` of `SherXERC20`
#142
code423n4
closed
3 years ago
2
Tokens cannot be reinitialized with new lock tokens
#141
code423n4
opened
3 years ago
1
Cannot set `watsonsSherxWeight` to the maximum
#140
code423n4
opened
3 years ago
2
Inconsistent block number comparison when deciding an unstaking entry is active
#139
code423n4
opened
3 years ago
0
Use `safeApprove` instead of `approve`
#138
code423n4
closed
3 years ago
1
Division using a division result
#137
code423n4
closed
3 years ago
1
Possible divide-by-zero error in `PoolBase`
#136
code423n4
opened
3 years ago
0
Missing non-zero address checks
#135
code423n4
opened
3 years ago
1
Missing zero address check for the recipient in `SherXERC20`
#134
code423n4
closed
3 years ago
1
SafeMath library is not always used in `PoolBase`
#133
code423n4
opened
3 years ago
0
Using unlocked/floating pragmas
#132
code423n4
closed
3 years ago
2
Difficult for the project to be decentralized if the Watsons share one address.
#131
code423n4
closed
3 years ago
2
order of operations in Payout.sol
#130
code423n4
opened
3 years ago
2
Confusing exponentiation (10e17)
#129
code423n4
opened
3 years ago
1
If statement should output ps.protoclBalance if amount > ps.protocolBalance
#128
code423n4
closed
3 years ago
2
Uncheckable math in `redeem()`
#127
code423n4
opened
3 years ago
1
uncheckable math in `payout()`
#126
code423n4
opened
3 years ago
1
NatSpec typo in `_doSherX` @return
#125
code423n4
opened
3 years ago
1
gas reduction in `calcUnderlying`
#124
code423n4
opened
3 years ago
1
Poorly Named variables
#123
code423n4
opened
3 years ago
3
Token price should not be set manually.
#122
code423n4
closed
3 years ago
2
Unnecessary require + if combination.
#121
code423n4
closed
3 years ago
2
Unused functions and storage cost gas.
#120
code423n4
opened
3 years ago
1
Single under-funded protocol can break paying off debt
#119
code423n4
opened
3 years ago
1
ERC20 can accidentally burn tokens
#118
code423n4
opened
3 years ago
1
ERC20 non-standard names
#117
code423n4
opened
3 years ago
3
`initializeSherXERC20` can be called more than once
#116
code423n4
opened
3 years ago
0
Sanitize `_weights` in `setWeights` on every use
#115
code423n4
opened
3 years ago
1
Anyone can unstake on behalf of someone
#114
code423n4
opened
3 years ago
0
`activateCooldownFee` can be more than 100%
#113
code423n4
closed
3 years ago
3
[Gas optimizations] - Public functions that are public, but could be external
#112
code423n4
opened
3 years ago
0
Deposits don't work with fee-on transfer tokens
#111
code423n4
closed
3 years ago
1
`TokenToLock` default value
#110
code423n4
opened
3 years ago
3
`Payout.deduction` computation uses wrong decimals
#109
code423n4
closed
3 years ago
3
`_doSherX` does not return correct precision and it's confusing
#108
code423n4
opened
3 years ago
0
`_doSherX` optimistically assumes premiums will be paid
#107
code423n4
opened
3 years ago
1
Missing verification in `setProtocolPremium`
#106
code423n4
closed
3 years ago
2
Missing verification on `tokenInit`'s lock
#105
code423n4
opened
3 years ago
1
Unbounded iteration over all protocols
#104
code423n4
opened
3 years ago
0
Unbounded iteration over all staking tokens
#103
code423n4
opened
3 years ago
0
Unbounded iteration over all premium tokens
#102
code423n4
opened
3 years ago
0
Government initializer functions can be frontrun
#101
code423n4
closed
3 years ago
3
Next