code-423n4 2021-10-mochi-findings issues

code-423n4 / 2021-10-mochi-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

`MochiVault.flashFee()` May Truncate Result

#171 code423n4 opened 3 years ago
2
`flashLoan()` is Lacking Protections Against Reentrancy

#170 code423n4 opened 3 years ago
2
`MochiEngine.sol` Does Not Emit Events For State Changing Functions

#169 code423n4 closed 3 years ago
1
`MochiTreasuryV0.sol` Is Unusable In Its Current State

#168 code423n4 opened 3 years ago
0
Mochi Protocol Is Lacking Extensive Test Coverage

#167 code423n4 opened 3 years ago
2
Separate CSSR historic data update and user facing operations

#166 code423n4 closed 3 years ago
2
Validations

#165 code423n4 closed 3 years ago
1
Gas optimizations (code simplification, memory variables addition or removal)

#164 code423n4 closed 3 years ago
0
`MochiTreasuryV0.claimOperationCost()` Writes State Variable After An External Call Is Made

#163 code423n4 opened 3 years ago
2
`MochiTreasuryV0.sol` Implements `receive()` Function With No Withdraw Mechanism

#162 code423n4 opened 3 years ago
2
`MochiTreasuryV0.withdrawLock()` Is Callable When Locking Has Been Toggled

#161 code423n4 opened 3 years ago
0
Duplicate check of supported token on flash loan

#160 code423n4 closed 3 years ago
0
debts <= _amount

#159 code423n4 opened 3 years ago
2
Duplicate math operations

#158 code423n4 opened 3 years ago
0
Cache duplicate access of storage variables

#157 code423n4 closed 3 years ago
1
Unchecked math

#156 code423n4 opened 3 years ago
2
Improper Validation Of `create2` Return Value

#155 code423n4 opened 3 years ago
0
Useless imports

#154 code423n4 opened 3 years ago
0
Pack structs tightly

#153 code423n4 opened 3 years ago
0
Cache the results of duplicate external calls

#152 code423n4 opened 3 years ago
0
Two-step change of a governance address

#151 code423n4 closed 3 years ago
2
Improve precision and gas costs in_shareMochi

#150 code423n4 opened 3 years ago
0
claimRewardAsMochi will produce a runtime error

#149 code423n4 closed 3 years ago
1
Chainlink Adapter Missing Validation Of `latestRoundData()` Outputs

#148 code423n4 closed 3 years ago
1
Explicit type setting in MochiCSSRv0 definitions (clearer code, saving type conversion gas)

#147 code423n4 closed 3 years ago
1
Events on key Vault actions

#146 code423n4 closed 3 years ago
1
Avoid Using Block.timestamp in checkClaimable

#145 code423n4 closed 3 years ago
2
Owner has unlimited minting capability

#144 code423n4 closed 3 years ago
1
Historic data being requested as a part of MochiVault.withdraw and borrow functions can be outdated, so a user can avoid historic data update with sending old piece of _data

#143 code423n4 closed 3 years ago
2
Transfer function is unreliable

#142 code423n4 closed 3 years ago
2
Lack of data validation in update function

#141 code423n4 closed 3 years ago
1
getLiquidity() should be external

#140 code423n4 closed 3 years ago
1
Open TODOs/questions

#139 code423n4 opened 3 years ago
0
Comment typos

#138 code423n4 closed 3 years ago
0
Uniswap / Sushiswap prices can be manipulated through flashloans

#137 code423n4 closed 3 years ago
2
`UniswapV2CSSR` assumes data was observed when block state was inserted

#136 code423n4 closed 3 years ago
0
UniswapV2TokenAdapter does not support Sushiswap-only assets

#135 code423n4 closed 3 years ago
0
UniswapV2/SushiwapLPAdapter update the wrong token

#134 code423n4 opened 3 years ago
0
ChainLink price data could be stale

#133 code423n4 closed 3 years ago
1
Missing low-level call success check

#132 code423n4 closed 3 years ago
1
"Liquidated" status never set on NFT

#131 code423n4 closed 3 years ago
1
Changing engine.nft contract breaks vaults

#130 code423n4 opened 3 years ago
0
Debt accrual is path-dependant and inaccurate

#129 code423n4 opened 3 years ago
0
Unsafe `int256` casts in `accrueDebt`

#128 code423n4 closed 3 years ago
0
A malicious user can potentially escape liquidation by creating a dust amount position and trigger the liquidation by themself

#127 code423n4 opened 3 years ago
0
liquidation factor < collateral factor for Sigma type

#126 code423n4 opened 3 years ago
0
Missing slippage checks

#125 code423n4 closed 3 years ago
1
Flashloan fee griefing attack for existing approvals

#124 code423n4 opened 3 years ago
0
Mochi fees can be accidentally burned

#123 code423n4 closed 3 years ago
0
Key currencies can be double counted

#122 code423n4 opened 3 years ago
0