code-423n4 2021-10-union-findings issues

code-423n4 / 2021-10-union-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

WadRayMath state variables

#110 code423n4 opened 3 years ago
1
Lack of precision in wadDiv

#109 code423n4 opened 3 years ago
1
Admin has too much power

#108 code423n4 closed 3 years ago
2
Treasury setAdmin function

#107 code423n4 closed 3 years ago
2
caching multiple used variables

#106 code423n4 opened 3 years ago
1
Gas efficiency suggestions

#105 code423n4 opened 3 years ago
1
AssetManager's rebalance function can fail if the last moneyMarket doesn't support a token and the balance gathered is odd

#104 code423n4 closed 3 years ago
3
double reading from memory inside a for loop.

#103 code423n4 opened 3 years ago
1
--j is more gas efficient than j--.

#102 code423n4 opened 3 years ago
0
At some places, array length is not cached.

#101 code423n4 closed 3 years ago
1
More efficient loops

#100 code423n4 opened 3 years ago
1
UToken ERC20 function is inherited and not override

#99 code423n4 closed 3 years ago
1
UToken.uErc20 field could be immutable

#98 code423n4 opened 3 years ago
1
UToken.__UToken_init can be frontrun

#97 code423n4 opened 3 years ago
1
Lack of address input verification - UToken.repayBorrowWithPermit

#96 code423n4 closed 3 years ago
2
UToken.sol _redeemFresh could be set private instead internal

#95 code423n4 opened 3 years ago
1
Open TODOs in `Treasury.sol`

#94 code423n4 opened 3 years ago
1
Unchecked math operations

#93 code423n4 opened 3 years ago
1
.length in a loop

#92 code423n4 opened 3 years ago
1
Zero transfers

#91 code423n4 opened 3 years ago
1
Pre-calculate known values

#90 code423n4 opened 3 years ago
1
list of _admins

#89 code423n4 opened 3 years ago
1
Struct with only 1 element

#88 code423n4 opened 3 years ago
1
Immutable variables

#87 code423n4 opened 3 years ago
1
getSupply and getSupplyView are identical

#86 code423n4 opened 3 years ago
1
Unbounded loops

#85 code423n4 closed 3 years ago
1
Two-step change of a critical parameter

#84 code423n4 opened 3 years ago
2
deposit onlyAssetManager

#83 code423n4 opened 3 years ago
2
Validation in addSchedule

#82 code423n4 closed 3 years ago
2
Wrong implementation of `CreditLimitByMedian.sol#getLockedAmount()` will lock a much bigger total amount of staked tokens than expected

#81 code423n4 opened 3 years ago
11
Wrong implementation of `CreditLimitByMedian.sol#getLockedAmount()` makes it unable to unlock `lockedAmount` in `CreditLimitByMedian` model

#80 code423n4 opened 3 years ago
1
Wrong calculation of `FrozenCoinAge`

#79 code423n4 closed 3 years ago
2
Comptroller rewards can be artificially inflated and drained by manipulating [totalStaked - totalFrozen] (or: wrong rewards calculation)

#78 code423n4 opened 3 years ago
1
`UToken.sol` should inherits and complies with `IUToken.sol`

#77 code423n4 opened 3 years ago
1
`Controller.sol#__Controller_init()` Inappropriate function visibility

#76 code423n4 closed 3 years ago
2
Gas: Explicit overflow checks even though solidity 0.8 is used (2)

#75 code423n4 opened 3 years ago
1
Gas: Explicit overflow checks even though solidity 0.8 is used (1)

#74 code423n4 opened 3 years ago
1
Gas: `CompoundAdapter` should approve `cToken` addresses once

#73 code423n4 closed 3 years ago
1
Gas: `AssetManager.getMoneyMarket` use assignment

#72 code423n4 opened 3 years ago
1
Gas: `AssetManager.rebalance` cache last market

#71 code423n4 opened 3 years ago
1
Gas: `AssetManager.deposit` cam be simplified

#70 code423n4 closed 3 years ago
1
`UnionToken` should check whitelist on `from`?

#69 code423n4 opened 3 years ago
1
`withdrawRewards` should send remaining balance

#68 code423n4 opened 3 years ago
1
`repayBorrowWithPermit` is missing `nonReentrant`

#67 code423n4 opened 3 years ago
1
`borrow` must `accrueInterest` first

#66 code423n4 opened 3 years ago
1
Unbounded iteration in `deleteMarket`

#65 code423n4 opened 3 years ago
1
Rebalance will fail due to low precision of percentages

#64 code423n4 opened 3 years ago
0
Rebalance will fail if a market has high utilization

#63 code423n4 opened 3 years ago
1
`withdrawSeq` might not be set

#62 code423n4 opened 3 years ago
1
Code Style: constants should be named in all caps

#61 code423n4 opened 3 years ago
1