issues
search
code-423n4
/
2021-12-yetifinance-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
rong comment in `getFee`
#203
code423n4
opened
2 years ago
2
`lastFeePercent` can be > 100%
#202
code423n4
opened
2 years ago
2
`lastFeeTime` can be reset
#201
code423n4
opened
2 years ago
2
Cannot use most piecewise linear functions with current implementation
#200
code423n4
opened
2 years ago
2
Missing cutoff checks in `adjustParams`
#199
code423n4
opened
2 years ago
1
Collateral parameters can be overwritten
#198
code423n4
opened
2 years ago
2
Missing duplicate checks in `withdrawColl`
#197
code423n4
opened
2 years ago
2
No ERC20 safe* versions called
#196
code423n4
closed
2 years ago
4
`setAddresses` functions can be frontrun
#195
code423n4
closed
2 years ago
1
Assert is a waste of gas
#194
code423n4
closed
2 years ago
2
Upgrade pragma to at least 0.8.4
#193
code423n4
closed
2 years ago
1
validCollateral[0] can be added multiple times
#192
code423n4
closed
2 years ago
1
Race condition in approve()
#191
code423n4
closed
2 years ago
2
StabilityPool.receiveCollateral function doesn't have access control
#190
code423n4
closed
2 years ago
1
contracts/Dependencies/CheckContract.sol has a potential gas optimization
#189
code423n4
opened
2 years ago
0
contracts/TroveManagerRedemptions.sol is missing inheritance
#188
code423n4
opened
2 years ago
1
contracts/TroveManagerLiquidations.sol is missing inheritance
#187
code423n4
opened
2 years ago
1
Function getCurrentICR() can be made external
#186
code423n4
closed
2 years ago
3
Re-entrancy in contracts/TroveManager.sol
#185
code423n4
closed
2 years ago
3
Dead code in contracts/BorrowerOperations.sol
#184
code423n4
closed
2 years ago
1
Reentrancy in contracts/BorrowerOperations.sol
#183
code423n4
opened
2 years ago
2
No version pragma in 'contracts/TellorDummy.sol'
#182
code423n4
closed
2 years ago
1
NamespaceCollision: Multiple SafeMath contracts
#181
code423n4
opened
2 years ago
3
Multiple contracts or interfaces with the same name
#180
code423n4
opened
2 years ago
1
Change function visibility from public to external
#179
code423n4
closed
2 years ago
2
Change function visibility from public to external
#178
code423n4
closed
2 years ago
3
Unnecessary uint zero initialization
#177
code423n4
closed
2 years ago
2
Revert string > 32 bytes
#176
code423n4
closed
2 years ago
1
"constants" expressions are expressions, not constants, so constant `keccak` variables results in extra hashing (and so gas).
#175
code423n4
opened
2 years ago
2
Use calldata instead of memory for external function parameters
#174
code423n4
closed
2 years ago
1
!= 0 costs less gass compared to > 0 for unsigned integer inside pure or view functions
#173
code423n4
opened
2 years ago
2
Tautology on "variable >= 0" which is always true as variable is uint
#172
code423n4
closed
2 years ago
1
Check if transfer amount > 0
#171
code423n4
opened
2 years ago
1
Explicit initialization with zero not required
#170
code423n4
opened
2 years ago
2
Bytes constants are more efficient than string constants
#169
code423n4
opened
2 years ago
2
Use of uint8 for counter in for loop increases gas costs
#168
code423n4
opened
2 years ago
2
Incompatibility With Rebasing/Deflationary/Inflationary tokens
#167
code423n4
opened
2 years ago
3
An array's length should be cached to save gas in for-loops
#166
code423n4
closed
2 years ago
2
Cache array length in for loops can save gas
#165
code423n4
closed
2 years ago
2
Use `calldata` instead of `memory` for function parameters
#164
code423n4
opened
2 years ago
1
Missing validation of address argument could indefinitely lock treasury
#163
code423n4
closed
2 years ago
3
Declare state variables as immutable
#162
code423n4
opened
2 years ago
1
Long revert string reasons
#161
code423n4
closed
2 years ago
1
Useless require
#160
code423n4
closed
2 years ago
1
Leftover console.log calls
#159
code423n4
closed
2 years ago
1
Mixed compiler versions
#158
code423n4
opened
2 years ago
3
Usage of assert() instead of require()
#157
code423n4
opened
2 years ago
2
test
#156
code423n4
closed
2 years ago
1
Open TODOs
#155
code423n4
closed
2 years ago
2
Require without a message
#154
code423n4
closed
2 years ago
4
Previous
Next