code-423n4 2022-01-insure-findings issues

code-423n4 / 2022-01-insure-findings

2 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Gas Optimizations

#362 code423n4 opened 2 years ago
0
Gas: Avoid expensive calculation by checking if `originalLiquidity() == 0`

#361 code423n4 opened 2 years ago
0
Gas: Cache `lockedAmount` in `PoolTemplate.sol:utilizationRate()`

#360 code423n4 closed 2 years ago
1
Expired insurance status set incorrectly after unlock of funds

#359 code423n4 closed 2 years ago
1
Gas: Cache `totalSupply()` in `PoolTemplate.sol:rate()`

#358 code423n4 closed 2 years ago
1
Missing divide by 0 checks for `_liquidity` (` == totalLiquidity()`)

#357 code423n4 closed 2 years ago
2
Inconsistent divide by 0 checks for `totalLiquidity()`

#356 code423n4 closed 2 years ago
1
Gas: Optimize Conditional Statements in `PoolTemplate.sol:worth()`

#355 code423n4 opened 2 years ago
1
Index compensate is 0 when totalLiquidity() is enough to cover the whole amount

#354 code423n4 opened 2 years ago
1
"> 0" is less efficient than "!= 0" for unsigned integers

#353 code423n4 closed 2 years ago
1
Unbounded iteration over all indexes (2)

#352 code423n4 opened 2 years ago
4
Unbounded iteration over all indexes

#351 code423n4 closed 2 years ago
1
Gas: `incident.payoutDenominator` is used only once. It shouldn't be stored in a variable.

#350 code423n4 opened 2 years ago
0
Gas: `incident.payoutNumerator` is used only once. It shouldn't be stored in a variable.

#349 code423n4 opened 2 years ago
0
`PoolTemplate:redeem()::_insurance`'s data location should be `memory`

#348 code423n4 closed 2 years ago
2
Insurance Pool Locking Does Not Propagate To All Markets

#347 code423n4 opened 2 years ago
1
Gas: `PoolTemplate:initialize()::_references` should be a fixed array of size 5

#346 code423n4 closed 2 years ago
2
Gas: `PoolTemplate:initialize()::_conditions` should be a fixed array of size 2

#345 code423n4 opened 2 years ago
1
Gas: Avoid expensive calculation by checking if `valueAll() == 0`

#344 code423n4 opened 2 years ago
1
Gas: Cache `attributions[_target]` in `Vault.sol:underlyingValue()`

#343 code423n4 opened 2 years ago
1
Inconsistent divide by 0 checks for `totalAttributions`

#342 code423n4 closed 2 years ago
1
CDS Withdrawal changes are not persisted

#341 code423n4 closed 2 years ago
1
DOS: `Vault.sol:repayDebt()` allows desync between `totalDebt` and sum of `debts[]`

#340 code423n4 closed 2 years ago
1
Pause check missing on the several functions (PoolTemplate)

#339 code423n4 opened 2 years ago
0
Accounting for non-standard ERC20 fees

#338 code423n4 closed 2 years ago
1
Misleading comments and documentation

#337 code423n4 opened 2 years ago
1
Remove No Effect/Do Nothing Functions to Save Gas

#336 code423n4 closed 2 years ago
2
`applyCover()` Does Not Enforce Index Market Lock

#335 code423n4 closed 2 years ago
3
Ordering importance in a struct

#334 code423n4 opened 2 years ago
2
Owner can grief with fees

#333 code423n4 closed 2 years ago
1
Order of statements

#332 code423n4 opened 2 years ago
2
Missing divide by 0 check on `_pool` (`valueAll()`)

#331 code423n4 closed 2 years ago
1
Missing divide by 0 check on `_totalLiquidity`

#330 code423n4 closed 2 years ago
1
Use of assert() instead of require()

#329 code423n4 closed 2 years ago
2
Immutable variables

#328 code423n4 closed 2 years ago
2
Gas: Cache `_maxList[_target]` in `Parameters.sol:getMaxList()`

#327 code423n4 closed 2 years ago
2
Gas: Cache `_min[_target]` in `Parameters.sol:getMinDate()`

#326 code423n4 closed 2 years ago
1
Gas: Cache `_withdawable[_target]` in `Parameters.sol:getWithdrawable()`

#325 code423n4 closed 2 years ago
1
Gas: Cache `_lockup[_target]` in `Parameters.sol:getLockup()`

#324 code423n4 closed 2 years ago
1
Gas: Cache `_lowerSlack[_target]` in `Parameters.sol:getLowerSlack()`

#323 code423n4 closed 2 years ago
1
Redundant Sub Function

#322 code423n4 closed 2 years ago
2
Gas: Cache `_upperSlack[_target]` in `Parameters.sol:getUpperSlack()`

#321 code423n4 closed 2 years ago
1
Gas: Cache `_fee[_target]` in `Parameters.sol:getFeeRate()`

#320 code423n4 opened 2 years ago
3
Gas Optimization: Use external keyword instead of public for some functions

#319 code423n4 closed 2 years ago
2
Multiple has ==true comparison in require statement

#318 code423n4 closed 2 years ago
1
Gas Optimization: Use unchecked for safe math

#317 code423n4 opened 2 years ago
0
uint8 is cheaper than uint128

#316 code423n4 closed 2 years ago
3
Add a timelock to `Parameters:setFeeRate`

#315 code423n4 opened 2 years ago
4
Validate _to is not empty

#314 code423n4 opened 2 years ago
1
Unbounded iteration over all pools

#313 code423n4 closed 2 years ago
2