issues
search
code-423n4
/
2022-01-sherlock-findings
0
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Reentrancy
#283
code423n4
closed
2 years ago
1
Multiple Reentrancy
#282
code423n4
closed
2 years ago
1
addressShare is not updated on arbRestake
#281
code423n4
closed
2 years ago
1
missing whenNotPaused
#280
code423n4
opened
2 years ago
0
Same check is made twice
#279
code423n4
closed
2 years ago
1
Looping through storage is expensive
#278
code423n4
closed
2 years ago
1
Order of operations
#277
code423n4
closed
2 years ago
1
debt = balance
#276
code423n4
opened
2 years ago
0
Unchecked math operations
#275
code423n4
closed
2 years ago
1
Re-entrancy protection
#274
code423n4
opened
2 years ago
2
Pausable paused() is not enforced to be present
#273
code423n4
opened
2 years ago
1
Re-try withdrawAll from inactive strategy
#272
code423n4
closed
2 years ago
1
Claim SHER on behalf of others
#271
code423n4
opened
2 years ago
2
Slippage parameter for SherBuy
#270
code423n4
opened
2 years ago
2
safeApprove will fail if the current approval is not 0
#269
code423n4
opened
2 years ago
0
Big deposits will revert
#268
code423n4
closed
2 years ago
1
Withrawals will fail if the market has high utilization
#267
code423n4
opened
2 years ago
1
Impossible check wastes gas
#266
code423n4
closed
2 years ago
1
Restaking period could be disabled
#265
code423n4
closed
2 years ago
1
Anyone can withdraw others
#264
code423n4
closed
2 years ago
0
Use calldata instead of memory
#263
code423n4
closed
2 years ago
1
++i is more gas efficient than i++
#262
code423n4
closed
2 years ago
1
Unsafe reentrancy door
#261
code423n4
closed
2 years ago
1
Staking period required to buy sher tokens can be disabled
#260
code423n4
closed
2 years ago
1
Cheaper gas to check `address(this).balance` first then do the transfer
#259
code423n4
closed
2 years ago
1
cheaper to use negation to require if
#258
code423n4
closed
2 years ago
1
cheaper to use negation (!) than use require false for if
#257
code423n4
closed
2 years ago
1
cheaper to calculate stakeShares first then do the transfer
#256
code423n4
opened
2 years ago
0
double delete in forceRemoveByActiveBalance() is expensive
#255
code423n4
closed
2 years ago
1
cheaper to use !active()
#254
code423n4
closed
2 years ago
1
Adding unchecked directive can save gas
#253
code423n4
opened
2 years ago
0
checks effect interaction on execute function
#252
code423n4
closed
2 years ago
1
cheaper to use `!active()`
#251
code423n4
closed
2 years ago
1
anyone can call forceRemoveByActiveBalance()
#250
code423n4
closed
2 years ago
1
Cheaper to use calldata than memory
#249
code423n4
opened
2 years ago
0
unnecessary check on `block.chainid`
#248
code423n4
closed
2 years ago
0
Repeated calls might lead to DoS
#247
code423n4
closed
2 years ago
1
cheaper gas to use `claim.state` and `claim.updated`
#246
code423n4
closed
2 years ago
1
Unnecessary typcasting
#245
code423n4
opened
2 years ago
0
Array length read in for loop consumes more gas
#244
code423n4
closed
2 years ago
1
Name collision in SherlockClaimManager
#243
code423n4
closed
2 years ago
2
Non-transferable critical privileged role
#242
code423n4
closed
2 years ago
1
Hardcoded AAVE LendingPoolAddressesProvider
#241
code423n4
closed
2 years ago
1
Check if amount is not zero to save gas
#240
code423n4
closed
2 years ago
0
Name collision in `SherlockProtocolManager`
#239
code423n4
opened
2 years ago
1
Gas Optimization: Unnecessary check
#238
code423n4
closed
2 years ago
1
Gas Optimization: cache array length
#237
code423n4
closed
2 years ago
1
Gas Optimization: Struct layout
#236
code423n4
opened
2 years ago
0
Gas Optimization: fmul optimization
#235
code423n4
closed
2 years ago
1
Inline one time use functions
#234
code423n4
closed
2 years ago
0
Next