code-423n4 2022-01-sherlock-findings issues

code-423n4 / 2022-01-sherlock-findings

0 stars 0 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Unnecessary default assignment

#233 code423n4 closed 2 years ago
0
Inline one time use functions,

#232 code423n4 closed 2 years ago
1
Cache array length in for loops can save gas

#231 code423n4 opened 2 years ago
0
SherlockClaimManager: Incorrect amounts needed and paid for escalated claims

#230 code423n4 opened 2 years ago
4
ISherlockClaimManager: Outdated example on claims process

#229 code423n4 opened 2 years ago
1
SherlockClaimManager: Confusing comment on BOND

#228 code423n4 opened 2 years ago
1
SherlockClaimManager: Sanity check on _amount in escalate() should be stricter

#227 code423n4 closed 2 years ago
1
SherlockClaimManager: startClaim() has outdated comment

#226 code423n4 opened 2 years ago
1
Sherlock: Revert for non-existent ID in viewRewardForArbRestake

#225 code423n4 opened 2 years ago
0
SherBuy: Verify SHERClaim’s SHER token is equal to that of SherlockPosition’s

#224 code423n4 closed 2 years ago
1
Sherlock: Decouple yield strategy with withdrawals

#223 code423n4 closed 2 years ago
1
SherBuy: SHER and USDC token addresses should be derived from _sherlockPosition

#222 code423n4 opened 2 years ago
0
Sherlock: arbRestake() doesnt reduce addressShares of owner

#221 code423n4 closed 2 years ago
1
SherlockClaimManager: Clarify why sherlockCore is used as proposer in UMA.requestAndProposePriceFor()

#220 code423n4 opened 2 years ago
0
Grammar

#219 code423n4 opened 2 years ago
0
Inconsistent Acronym of UmaHaltOperator

#218 code423n4 opened 2 years ago
0
SherlockClaimManager: reentrancy comment for priceProposed() and priceDisputed() can be phrased better

#217 code423n4 opened 2 years ago
0
Spelling Errors

#216 code423n4 opened 2 years ago
0
SherDistributionManager: Cheaper to assign than add _tvl

#215 code423n4 opened 2 years ago
0
SherlockClaimManager: Cache array length

#214 code423n4 closed 2 years ago
1
SherBuy: Redundant ZeroArgument check for _sherlockPosition

#213 code423n4 closed 2 years ago
1
Skip checking booleans against true / false

#212 code423n4 closed 2 years ago
1
Manager: Check non-zero ETH balance before sending

#211 code423n4 opened 2 years ago
0
++i is more gas efficient than i++ in loops forwarding

#210 code423n4 closed 2 years ago
1
Replacing condition == false for !condition can saves gas.

#209 code423n4 closed 2 years ago
1
constant value should be private or internal.

#208 code423n4 closed 2 years ago
1
inheriting contracts don't have to import dependencies again.

#207 code423n4 closed 2 years ago
0
Contracts will break if USDC ever upgrades to fee-on-transfer

#206 code423n4 closed 2 years ago
1
SherBuy.sol should use increaseAllowance on sher instead of approve

#205 code423n4 closed 2 years ago
1
Users shouldn't be forced into a specific strategy (possible rug pull)

#204 code423n4 closed 2 years ago
2
Owner should be able to choose to not ignore failures in updateYieldStrategy

#203 code423n4 closed 2 years ago
1
Lack of precision in `allPremiumsPerSecToStakers` may cause reward denying

#202 code423n4 closed 2 years ago
1
Updating Manager contract could destruct Sherlock core functionalities

#201 code423n4 opened 2 years ago
1
Saving gas by used length

#200 code423n4 opened 2 years ago
0
`block.chainid` should be stored in a constant variable for more configuration visibility at deployment

#199 code423n4 closed 2 years ago
0
Arbitrager can potentially take more arbReward than expected.

#198 code423n4 closed 2 years ago
2
Gas in `Sherlock.sol:unpause()`: SLOADs minimization

#197 code423n4 closed 2 years ago
1
Gas in `Sherlock.sol:pause()`: SLOADs minimization

#196 code423n4 closed 2 years ago
1
Gas in `Sherlock.sol:updateYieldStrategy()`: SLOADs minimization

#195 code423n4 closed 2 years ago
1
Gas in `Sherlock.sol:updateSherDistributionManager()`: SLOADs minimization

#194 code423n4 closed 2 years ago
1
Gas: Non-strict inequalities are cheaper than strict ones

#193 code423n4 opened 2 years ago
0
`forceRemoveByActiveBalance()` is callable by anyone and is front-runnable

#192 code423n4 closed 2 years ago
1
`SherlockProtocolManager.sol`: `setMinActiveBalance()` and `forceRemoveByActiveBalance()` should be put behind a timelock

#191 code423n4 opened 2 years ago
1
`transferOwnership` should be a two-step process

#190 code423n4 closed 2 years ago
1
Redundant check in `SherBuy.execute`

#189 code423n4 closed 2 years ago
0
USDC is upgradeable: received amount should be calculated

#188 code423n4 opened 2 years ago
2
`sweepTokens`loop does not check for zero transfer amount

#187 code423n4 closed 2 years ago
1
Avoid unnecessary arithmetic operations

#186 code423n4 closed 2 years ago
1
10 ** 18 can be changed to 1e18 and save some gas

#185 code423n4 opened 2 years ago
0
A more efficient for loop index proceeding

#184 code423n4 closed 2 years ago
1

Previous Next