issues
search
code-423n4
/
2022-01-trader-joe-findings
2
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Long Revert Strings are Waste of Gas
#221
code423n4
closed
2 years ago
1
> 0 can be replaced with != 0 for gas optimisation
#220
code423n4
closed
2 years ago
1
Gas in `LaunchEvent.sol:pairBalance()`: `wavaxAllocated` should get cached
#219
code423n4
opened
2 years ago
0
Gas in `LaunchEvent.sol:getPenalty()`: `PHASE_ONE_DURATION` and `PHASE_ONE_NO_FEE_DURATION` should get cached
#218
code423n4
opened
2 years ago
0
Gas in `LaunchEvent.sol:emergencyWithdraw()`: `issuer` should get cached
#217
code423n4
opened
2 years ago
0
Gas in `LaunchEvent.sol:withdrawLiquidity()`: `tokenReserve` should get cached earlier
#216
code423n4
opened
2 years ago
0
Gas in `LaunchEvent.sol:createPair()`: `wavaxReserve` should get cached
#215
code423n4
opened
2 years ago
0
Gas in `LaunchEvent.sol:currentPhase()`: `auctionStart` and `PHASE_ONE_DURATION` should get cached
#214
code423n4
opened
2 years ago
0
Needed to be check, so not to got 0 value
#213
code423n4
closed
2 years ago
2
Adding unchecked directive can save gas
#212
code423n4
closed
2 years ago
1
Gas in `RocketJoeFactory.sol:createRJLaunchEvent()`: `wavax` should get cached
#211
code423n4
opened
2 years ago
0
Gas: `RocketJoeStaking.withdraw`
#210
code423n4
opened
2 years ago
1
Misleading comment in `LaunchEvent.getReserves`
#209
code423n4
opened
2 years ago
2
`LaunchEvent.tokenIncentivesPercent` wrong docs
#208
code423n4
opened
2 years ago
2
Gas in `RocketJoeStaking.sol:updatePool()`: `lastRewardTimestamp` should get cached
#207
code423n4
opened
2 years ago
0
Penalty Collector must be trusted
#206
code423n4
opened
2 years ago
0
Unchecked token transfers are used in LaunchEvent and RocketJoeFactory
#205
code423n4
closed
2 years ago
2
`UserWithdrawn` event not emitted
#204
code423n4
closed
2 years ago
2
`IssuingTokenDeposited` event not emitted
#203
code423n4
closed
2 years ago
2
Uninitialized `RocketJoeStaking.lastRewardTimestamp` can inflate `rJoe` supply
#202
code423n4
opened
2 years ago
1
`rJoeAmount` can never be less than the `_avaxAmount`
#201
code423n4
opened
2 years ago
1
Upgrade pragma to at least 0.8.4
#200
code423n4
closed
2 years ago
1
Users can lose value in emergency state
#199
code423n4
opened
2 years ago
1
ERC20 return values not checked
#198
code423n4
opened
2 years ago
2
Pair creation can be denied
#197
code423n4
opened
2 years ago
2
Gas in `RocketJoeStaking.sol:deposit()`: `accRJoePerShare` should get cached
#196
code423n4
opened
2 years ago
0
Launch event creation can be denied 2
#195
code423n4
closed
2 years ago
1
Launch event creation can be denied
#194
code423n4
closed
2 years ago
1
Wrong token allocation computation for token decimals != 18 if floor price not reached
#193
code423n4
opened
2 years ago
1
Gas in `RocketJoeStaking.sol:withdraw()`: `accRJoePerShare` should get cached
#192
code423n4
opened
2 years ago
0
Long Revert Strings
#191
code423n4
closed
2 years ago
1
Variables should be marked as immutable.
#190
code423n4
closed
2 years ago
1
Missing Zero Addresss Check
#189
code423n4
closed
2 years ago
1
Unchecked `approve()` calls.
#188
code423n4
closed
2 years ago
1
Gas in `RocketJoeStaking.sol:withdraw()`: `user.amount` should get cached and used for calculation
#187
code423n4
opened
2 years ago
0
Incorecct calculation between actual code and comment
#186
code423n4
opened
2 years ago
2
Gas in `RocketJoeStaking.sol:deposit()`: `user.amount` should get cached and used for calculation
#185
code423n4
opened
2 years ago
0
Gas in `RocketJoeFactory.sol:_emitLaunchedEvent()`: a value used only once shouldn't get cached
#184
code423n4
opened
2 years ago
0
Unchecked transfers may lead to funds lost.
#183
code423n4
closed
2 years ago
1
Gas in `LaunchEvent.sol:emergencyWithdraw()`: `user.balance` should get cached earlier
#182
code423n4
opened
2 years ago
0
The contracts use unlocked pragma
#181
code423n4
opened
2 years ago
2
Gas in `LaunchEvent.sol:withdrawLiquidity()`: `address(pair)` should get cached
#180
code423n4
opened
2 years ago
0
Gas in `LaunchEvent.sol:createPair()`: calculation should get cached
#179
code423n4
opened
2 years ago
0
Gas: Non-strict inequalities are cheaper than strict ones
#178
code423n4
opened
2 years ago
0
user.allocation is not decreasing
#177
code423n4
closed
2 years ago
2
Allowance set incorrectly
#176
code423n4
closed
2 years ago
1
owner has excess power
#175
code423n4
closed
2 years ago
2
Gas savings
#174
code423n4
opened
2 years ago
0
createPair can be griefed to never work
#173
code423n4
closed
2 years ago
2
Gas savings
#172
code423n4
closed
2 years ago
2
Previous
Next