issues
search
code-423n4
/
2022-01-trader-joe-findings
2
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Use Shift Right/Left instead of Division/Multiplication if possible
#271
code423n4
opened
2 years ago
0
Long Revert Strings
#270
code423n4
closed
2 years ago
1
Use != 0 instead of > 0 for Unsigned Integer Comparison
#269
code423n4
closed
2 years ago
1
Saving more gas by using immutable for `floorprice`
#268
code423n4
closed
2 years ago
2
Unused variale
#267
code423n4
closed
2 years ago
2
RocketJoeStaking.initialize arguments need to be checked
#266
code423n4
opened
2 years ago
1
using += to save gas
#265
code423n4
opened
2 years ago
1
LaunchEvent's createPair calls token.decimals() twice
#264
code423n4
closed
2 years ago
1
Missing consistent zero address checks
#263
code423n4
opened
2 years ago
1
Functions can be external
#262
code423n4
opened
2 years ago
1
possibility of minting rJOE tokens before ownership is changed to RocketJoeStaking
#261
code423n4
opened
2 years ago
0
using `unchecked` can save gas
#260
code423n4
opened
2 years ago
0
Mint approval can be done on another contract
#259
code423n4
closed
2 years ago
2
Use safeTransferFrom instead of transferFrom
#258
code423n4
closed
2 years ago
2
withdrawAVAX and withdraw can do unchecked subtraction
#257
code423n4
closed
2 years ago
1
Variable can be changed to immutable
#256
code423n4
closed
2 years ago
2
Improper Upper Bound Definition on the Fee
#255
code423n4
opened
2 years ago
1
Lack of checks for data passed into onlyOwner functions
#254
code423n4
closed
2 years ago
2
Setting the `rocketJoeFactory` address in the ` initialize()` can be frontrun by an attacker
#253
code423n4
closed
2 years ago
2
Users' tokens can be stuck inside LaunchEvent if the token doesn't revert on failed transfers
#252
code423n4
closed
2 years ago
2
LaunchEvent's createPair can be cause to always revert
#251
code423n4
closed
2 years ago
2
Missing zero address check
#250
code423n4
closed
2 years ago
1
Multiple Reentrancy possibilities
#249
code423n4
closed
2 years ago
1
`createRJLaunchEvent()` Multiple `launchEvent` can be created unexpectedly by reentrancy
#248
code423n4
opened
2 years ago
1
`createRJLaunchEvent()` can be called by anyone with 1 Wei of `_token` and stop others from creating RJLaunchEvent with the same token anymore
#247
code423n4
opened
2 years ago
1
Add liquidity before phase 3 can force the launch event to stop
#246
code423n4
closed
2 years ago
2
`RocketJoeFactory.sol#createRJLaunchEvent()` Check of `_issuer != address(0)`, `_token != address(0)`, `_tokenAmount > 0` can be done earlier to save gas
#245
code423n4
opened
2 years ago
1
Unchecked return value for `ERC20.approve` call
#244
code423n4
closed
2 years ago
1
Unchecked return value for `token.transfer` call
#243
code423n4
closed
2 years ago
2
Use short reason strings can save gas
#242
code423n4
opened
2 years ago
0
`Ownable` library is redundant
#241
code423n4
opened
2 years ago
2
"> 0" is less efficient than "!= 0" for unsigned integers
#240
code423n4
opened
2 years ago
1
Change unnecessary storage variables to constants can save gas
#239
code423n4
closed
2 years ago
2
Check if amount > 0 before token transfer can save gas
#238
code423n4
opened
2 years ago
2
Reuse existing storage variables' cache can save gas
#237
code423n4
closed
2 years ago
1
Cache external call results can save gas
#236
code423n4
opened
2 years ago
1
Redundant type casting
#235
code423n4
opened
2 years ago
2
Cache and read storage variables from the stack can save gas
#234
code423n4
opened
2 years ago
0
Adding unchecked directive can save gas
#233
code423n4
opened
2 years ago
0
Unchecked return value for `token.transferFrom` call
#232
code423n4
closed
2 years ago
2
Use immutable variables can save gas
#231
code423n4
closed
2 years ago
1
Code Style: non-constant should not be named in all caps
#230
code423n4
opened
2 years ago
1
Saving more gas by using `immutable phase`
#229
code423n4
opened
2 years ago
0
accRJoePerShare can stay constant rendering staking uselss and therefore launchpools unusable!
#228
code423n4
closed
2 years ago
2
Caching `rJoe` variable
#227
code423n4
opened
2 years ago
0
No slippage check on `deposit()` of `RocketJoeStaking.sol`
#226
code423n4
closed
2 years ago
2
depositAVAX() Require msg.sender != issuer is Waste of Gas
#225
code423n4
closed
2 years ago
2
Privilege Escalation by Front Run LaunchEvent initialize() and Replace address _issuer
#224
code423n4
closed
2 years ago
2
Mint() by OnlyOwner Lack of Zero Address Check for Address _to
#223
code423n4
opened
2 years ago
0
Use != 0 instead of > 0 to Save Gas
#222
code423n4
closed
2 years ago
1
Previous
Next