sherlock-audit 2024-02-optimism-2024-judging issues

sherlock-audit / 2024-02-optimism-2024-judging

6 stars 4 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

The checks below should be inclusive

#251 sherlock-admin2 closed 7 months ago
0
`DisputeGameFactory.findLatestGames` function code can be modified to improve efficiency

#250 sherlock-admin4 closed 7 months ago
0
`OptimismPortal2.checkWithdrawal` can be modified to make the code more efficient

#249 sherlock-admin3 closed 7 months ago
0
Withdrawal funds could be lost if sent to the address(0)

#248 sherlock-admin2 closed 7 months ago
0
no check for duplicate addresses in the array

#247 sherlock-admin4 closed 7 months ago
0
discrepency b/w natspec comment & code in prove method

#246 sherlock-admin3 closed 7 months ago
1
blacklisted disupute game should be checked while proving withdrawals

#245 sherlock-admin2 closed 7 months ago
0
usage of `transfer()` to recover funds instead of a low level call

#244 sherlock-admin4 closed 7 months ago
0
use `Ownable2StepUpgradeable` in place of `OwnableUpgradeable`

#243 sherlock-admin3 closed 7 months ago
0
depositTransaction function must revert in other cases.

#242 sherlock-admin2 closed 7 months ago
0
defender_wins status may not be proven.

#241 sherlock-admin4 closed 7 months ago
1
Discrepency between Natspec comment and logic implementation in `require`

#240 sherlock-admin3 closed 7 months ago
1
No need of both `fallback` & `receive` if calldata is not used

#239 sherlock-admin2 closed 7 months ago
0
the `unlock` method in `delayedWETH` is callable by anyone

#238 sherlock-admin4 closed 7 months ago
0
Discrepency between Natspec comment and logic implementation

#237 sherlock-admin3 closed 7 months ago
1
Potential Precision Loss Due to Division Before Multiplication

#236 sherlock-admin2 closed 7 months ago
0
No way to unblacklist DisputeGame in `OptimismPortal2` which may cause withdrawal by users of that DisputeGame to be permanently locked.

#235 sherlock-admin4 closed 7 months ago
0
Use of `Payable(msg.sender).transfer` in `WETH98.withdraw` may revert and cause problems with withdrawal

#234 sherlock-admin3 closed 7 months ago
0
Packing Comment is incorrect

#233 sherlock-admin2 closed 7 months ago
1
Quantitative comparison between bond pricing actual formula vs theoretical vs python implementation

#232 sherlock-admin4 closed 7 months ago
0
Clones Data Copying is incorrectly offset by 2 if using `swont@main` instead of `swont@master`

#231 sherlock-admin3 closed 7 months ago
0
QA/Low report

#230 sherlock-admin2 closed 7 months ago
0
QA/Low report

#229 sherlock-admin4 closed 7 months ago
0
QA/Low report

#228 sherlock-admin3 closed 7 months ago
0
Attacking an agreed upon counter claim further to the left leads to unexpected loss of bonds

#227 sherlock-admin2 closed 7 months ago
0
`resolveClaim` accepts ether without any purpose

#226 sherlock-admin4 closed 7 months ago
1
bareli - reentrancy attack may happen in "initialize()"

#225 sherlock-admin3 closed 7 months ago
1
mahmud - Incorrect Handling of External Call Failures in Withdrawal Finalization

#224 sherlock-admin2 closed 7 months ago
0
99Crits - DisputeGameFactory cant be set for OptimismPortal

#223 sherlock-admin4 closed 7 months ago
0
MiloTruck - `uint64` is too small to hold `indexAtDepth` for nodes below a depth of 64

#222 sherlock-admin3 closed 7 months ago
3
99Crits - Creation of multiple FaultDisputeGames for same output root and l2BlockNumber possible

#221 sherlock-admin2 closed 7 months ago
1
w42d3n - Unrestricted Creation of Games

#220 sherlock-admin4 closed 7 months ago
1
0xpep7 - Potential Stuck Ether in FaultDisputeGame Contract due to payable resolveClaim Function

#219 sherlock-admin3 closed 7 months ago
2
petro1912 - The protocol doesn't check at all if account has already claimed, or moved (for attack, and defense).

#218 sherlock-admin2 closed 7 months ago
0
Bauchibred - `DelayedWETH's` core functionalities(waiting/unlocking/withdrawing) flawly implemented

#217 sherlock-admin4 closed 7 months ago
0
w42d3n - Insufficient input validation in OptimismPortal2.sol

#216 sherlock-admin3 closed 7 months ago
1
bareli - wrong calculation of required bond in "getRequiredBond"

#215 sherlock-admin2 closed 7 months ago
1
0xpep7 - Continuous DelayedWETH.unlock Calls With Short Interval Would Extends Previous Unclaimed Withdrawals

#214 sherlock-admin4 closed 7 months ago
0
Ward - The presence of `extraData` in the UUID generation extends uniqueness to an unhealthy extent

#213 sherlock-admin3 closed 7 months ago
0
MiloTruck - Dispute games can be infinitely played when `MAX_GAME_DEPTH = 127`

#212 sherlock-admin2 closed 7 months ago
3
Trust - An unbound loop at the resolveClaim() function allows anyone to permanently brick the claim

#211 sherlock-admin4 closed 7 months ago
1
turvec - The timestamp of the game's global resolution can always get modified even after already set

#210 sherlock-admin3 closed 7 months ago
1
0xpep7 - Incomplete Error Recovery Mechanism in DelayedWETH.hold function

#209 sherlock-admin2 closed 7 months ago
0
0xDjango - Chess Clock can be gamed, leading to theft of ETH bonds

#208 sherlock-admin4 closed 7 months ago
1
nirohgo - Blacklisting a game does not remove it from the AnchorStateRegistry, forcing subsequent games to use it as the starting Claim which disrupts their correct resolution.

#207 sherlock-admin3 closed 7 months ago
0
Trust - Anyone can freeze future withdrawals and any L2->L1 messaging due to mismatch between the VM-viewed block number and the user supplied block number.

#206 sherlock-admin2 closed 7 months ago
0
nirohgo - The FGD l2BlockNumber (passed in extraData) can be any number, enabling a DOS on fund widthdrawals

#205 sherlock-admin4 closed 7 months ago
0
turvec - WETH98 uses transfer instead of call which can break with future updates to gas costs

#204 sherlock-admin3 closed 7 months ago
0
Trust - Various defenses can be bypassed to make a created game unresolvable

#203 sherlock-admin2 closed 7 months ago
10
Trust - Incorrect enforcement of bottom-up resolution leads to unresolvable claims

#202 sherlock-admin4 closed 7 months ago
1