-
# Handle
heiho1
# Vulnerability details
## Impact
TroveManagerLiquidations does not inherit contracts/Interfaces/ITroveManagerLiquidations.sol but should. Note that TroveManager.sol
does inheri…
-
# Handle
heiho1
# Vulnerability details
## Impact
TroveManagerRedemptions does not inherit contracts/Interfaces/ITroveManagerRedemptions.sol but should. Note that TroveManager.sol does inherit I…
-
Hey There
I found some ways of optimization for your code that I thought I could share with you.
No looping is ever needed for this contract:
- For deleting an heir part you could set their wei…
-
# Handle
Dravee
# Vulnerability details
Here's the only `_investWETHToBuyNOTE()` call:
```
File: TreasuryManager.sol
140: function investWETHToBuyNOTE(uint256 wethAmount) external onlyManager …
-
# Handle
WatchPug
# Vulnerability details
ttps://github.com/code-423n4/2022-01-notional/blob/d171cad9e86e0d02e0909eb66d4c24ab6ea6b982/contracts/sNOTE.sol#L195-L209
```solidity
BALANCER_VAULT.join…
-
# Handle
WatchPug
# Vulnerability details
For the `Transfer` event, `amount` is expected to be the amount of tokens transferred, usually equal to the allowance decreased.
However, in the `transfe…
-
# Handle
WatchPug
# Vulnerability details
`newController.owner` should be validated to make sure the new owner's address is not `address(0)`.
Otherwise, if the owner mistakenly calls `updateContr…
-
# Handle
0x0x0x
# Vulnerability details
At `Product.sol#closeAll` cache `_position[account]` to save gas.
In the first line of the function `_position[account]` is used twice and gas can be save…
-
# Handle
0x0x0x
# Vulnerability details
## Concept
When `requery` is called, `token1OutBase` can get updated. `token1OutBase` is a crucial parameter, which directly tells how many tokens will th…
-
# Handle
ye0lde
# Vulnerability details
## Impact
Gas savings and code clarity
## Proof of Concept
The local variables on the lines below are declared to store the return values from `requery` …