issues
search
code-423n4
/
2022-01-yield-findings
1
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Malicious Users Can Transfer Vault Collateral To Other Accounts To Extract Additional Yield From The Protocol
#89
code423n4
opened
2 years ago
3
Only passing in one depositedBalance in _checkpointAndClaim()
#88
code423n4
opened
2 years ago
5
unwrap() can be called by anybody leading to loss of funds.
#87
code423n4
closed
2 years ago
2
Malicious Users Can Duplicate Protocol Earned Yield By Transferring `wCVX` Tokens To Another Account
#86
code423n4
opened
2 years ago
3
ConvexStakingWrapper does not update rewards state before transferring tokens
#85
code423n4
closed
2 years ago
2
Immutable variables
#84
code423n4
closed
2 years ago
1
`> 0 can be replaced with != 0 for gas optimization`
#83
code423n4
closed
2 years ago
1
++i is more gas efficient than i++ in loops forwarding
#82
code423n4
closed
2 years ago
1
Make full use of immutable keyword in ConvexStakingWrapper
#81
code423n4
closed
2 years ago
2
Extra SLOADs in _peek
#80
code423n4
closed
2 years ago
1
Unnecessary check on quote in Cvx3CrvOracle
#79
code423n4
opened
2 years ago
1
Cvx3CrvOracle does not check that Chainlink data is fresh.
#78
code423n4
closed
2 years ago
1
Gas (unrecommended): Mark functions as payable to save gas
#77
code423n4
closed
2 years ago
2
`ConvexStakingWrapper.sol`: related data should be grouped in a struct
#76
code423n4
opened
2 years ago
2
`ConvexStakingWrapper.sol`: `AccessControl` capabilities aren't used
#75
code423n4
opened
2 years ago
1
`ConvexStakingWrapper.sol`: unused `nonReentrant` modifier
#74
code423n4
opened
2 years ago
1
Use newer solidity version for `extcodesize` optimization
#73
code423n4
closed
2 years ago
3
less gas usage by calling the `TransferHelper` lib directly
#72
code423n4
opened
2 years ago
2
The visibility of ConvexYieldWrapper.removeVault should be changed to external.
#71
code423n4
closed
2 years ago
1
Gas in `Cvx3CrvOracle.sol:_peek()`: `ethId` and `cvx3CrvId` should get cached
#70
code423n4
opened
2 years ago
1
Gas in `Cvx3CrvOracle.sol:_peek()`: `minStable` can't overflow, as the comment states. Uncheck it.
#69
code423n4
closed
2 years ago
2
Gas in `Cvx3CrvOracle.sol:min()`: Non-strict inequalities are cheaper than strict ones
#68
code423n4
closed
2 years ago
2
Gas in `ConvexStakingWrapper.sol:_calcRewardIntegral()`: `bal - rewardRemaining` can't underflow
#67
code423n4
opened
2 years ago
1
Gas in `CvxMining.sol:ConvertCrvToCvx()`: `reduction` can't underflow
#66
code423n4
closed
2 years ago
3
Gas in `ConvexStakingWrapper.sol:removeVault()`: `vaultsLength - 1` can't underflow
#65
code423n4
closed
2 years ago
3
Gas in `ConvexStakingWrapper.sol:_calcRewardIntegral()`: Unnecessary checked arithmetic when no underflow possible
#64
code423n4
closed
2 years ago
3
Improvable decentralization
#63
code423n4
closed
2 years ago
2
Gas in `ConvexStakingWrapper.sol:addRewards()`: `startIndex` can't underflow
#62
code423n4
closed
2 years ago
2
Lack of auth for vaults
#61
code423n4
closed
2 years ago
2
Gas: Unused Named Returns
#60
code423n4
opened
2 years ago
2
Gas saving using ++i
#59
code423n4
closed
2 years ago
1
Gas: Tight variable packing in `ConvexStakingWrapper.sol`
#58
code423n4
opened
2 years ago
4
Gas: `> 0` is less efficient than `!= 0` for unsigned integers
#57
code423n4
opened
2 years ago
4
Gas: No need to initialize variables with default values
#56
code423n4
opened
2 years ago
3
Gas: `++i` costs less gas compared to `i++`
#55
code423n4
closed
2 years ago
1
Typos
#54
code423n4
opened
2 years ago
1
Oracle might return stale or incorrect results (Cvx3CrvOracle.sol)
#53
code423n4
closed
2 years ago
1
Unsafe approve
#52
code423n4
closed
2 years ago
2
approve Optimization
#51
code423n4
closed
2 years ago
2
using ++rewardsLength can be saving more gas
#50
code423n4
closed
2 years ago
1
caching curveToken in memory can cost less gas
#49
code423n4
opened
2 years ago
1
`immutable` can saving more gas
#48
code423n4
closed
2 years ago
1
check input address on constructor is not got zero address
#47
code423n4
closed
2 years ago
3
more efficient nonReentrant() modifier.
#46
code423n4
closed
2 years ago
2
Extend [ Possible logic missmatch ]
#45
code423n4
closed
2 years ago
4
Using ++i instead i++ for saving more gas
#44
code423n4
closed
2 years ago
2
Lack of important event
#43
code423n4
opened
2 years ago
1
Gas saving using immutable
#42
code423n4
opened
2 years ago
3
Oracle prices could be not fresh
#41
code423n4
closed
2 years ago
2
Unsecure oracle price
#40
code423n4
closed
2 years ago
3
Previous
Next