tokamak-network crossTrade issues

tokamak-network / crossTrade

Cross Trade is a new core service for optimistic rollups that complements standard withdrawals and fast withdrawals. It is trustless and do not require extensive backend.

4 stars 1 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Public Test Issue Application

#57 zzooppii opened 6 minutes ago
0
Insufficient warning for provideCT, editCT, claimCT

#56 suahnkim opened 1 month ago
1
for requestRegisteredToken() _totalAmount should not be greater than _ctAmount

#55 suahnkim closed 1 month ago
7
README 2. crossTrade Test -update json

#54 NegruGeorge opened 2 months ago
0
Improve "HOW TO TEST" Section in README for ease of use. Documentation && enhancement

#53 NegruGeorge opened 2 months ago
0
Deploy & setting the CrossTradeContract on Sepolia & Titan Sepolia

#52 zzooppii closed 2 months ago
1
make document for FrontEnd

#51 zzooppii closed 2 months ago
2
Open Thanos-Sepolia service

#50 usgeeus closed 3 months ago
0
[checking: security vulnerability] Function claimCT can be called with incorrect msg.sender

#49 nguyenzung closed 3 months ago
13
Use indexed paramter for events for off-chain searching

#48 parth-15 closed 3 months ago
0
if-else ladder in provideCT can be optimized

#47 parth-15 closed 3 months ago
3
Different `l1Token` and `l2Token` pair order will mostly remain unfulfilled

#46 parth-15 closed 3 months ago
24
Provider condition is checked twice in `claimCT` and `cancelCT`

#45 parth-15 closed 3 months ago
3
`claimCT` and `cancelCT` shouldn't be payable

#44 parth-15 closed 3 months ago
0
Setting `Provider` address as `msg.sender` can result in permanant loss of funds

#43 parth-15 closed 3 months ago
32
[non-critical] remove `require(dealData[_saleCount].provider == address(0)` where modifier `providerCheck` is applied

#42 usgeeus closed 3 months ago
0
[security vulnerbility] check `_totalAmount > _fwAmount` in requestRegisteredToken function

#41 usgeeus closed 3 months ago
3
[Gas Efficiencies] cache storage value to stack or memory

#40 usgeeus closed 3 months ago
0
getEnterHash function and checkToken mapping is not needed and can be removed

#39 parth-15 closed 3 months ago
0
function _approve is redundant and should be removed

#38 parth-15 closed 3 months ago
0
[Non-critical] change function name `chainInfo` to `setChainInfo`

#37 usgeeus closed 3 months ago
1
[Gas Efficiencies] make `crossDomainMessenger` immutable

#36 usgeeus closed 3 months ago
1
[Gas Efficiencies] use `else` insteand of `else if (number ==2)` in makeEncodeWithSignature, post #34 issue

#35 usgeeus closed 3 months ago
0
[Gas Efficiencies] optimize gas costs by modifying function visibility

#34 usgeeus closed 2 months ago
5
[Non-criticial] Make 1,2 constant for the type of the function, and make 0 constant for saleCount when cancel

#33 usgeeus closed 3 months ago
4
[Non-critical] Rename the function from _approve to _checkAllowance.

#32 usgeeus closed 3 months ago
2
[security vulnerability] A cross trade can be blocked by attackers

#31 nguyenzung closed 3 months ago
8
[security vulnerability] requestRegisteredToken is not safe

#30 nguyenzung closed 3 months ago
6
[security vulnerability] attackers can take all token on L2 with very small amount of token on L1

#29 nguyenzung closed 3 months ago
7
[security checking] claimFW can be failed in some cases

#28 nguyenzung closed 3 months ago
4
[optimize] many storage load

#27 DevUreak closed 3 months ago
3
apply codeReview feedback

#26 zzooppii closed 2 months ago
0
Write an article for Contract part

#25 zzooppii opened 3 months ago
7
add Testing for further development

#24 zzooppii opened 3 months ago
24
make the Document for 2nd Audit

#23 zzooppii closed 3 months ago
3
Editing function modification based on L1

#22 zzooppii closed 3 months ago
0
L2 reentrant logic development

#21 zzooppii closed 3 months ago
0
Sub-task or description

#20 zzooppii closed 4 months ago
0
Development of token management logic supported by CrossTrade

#18 zzooppii closed 3 months ago
0
hash does not contain block.time of FW request from L2

#17 suahnkim closed 4 months ago
4
test

#16 zzooppii closed 4 months ago
0
M_3. Transfer return value check & Assembly Check [low ~ medium]

#15 MarkInc3 closed 4 months ago
2
J_12 use check-effect-interaction pattern [low~medium]

#14 usgeeus closed 4 months ago
2
J_11 cache storage value to stack or memory [gas optimization]

#13 usgeeus closed 4 months ago
2
J_9 variable starts with lowercase [style guide]

#12 usgeeus closed 4 months ago
2
J_10 [protocol discussion]

#11 usgeeus closed 3 months ago
7
J_8. optimize getChainId function [optimization]

#10 usgeeus closed 4 months ago
3
J_7. add amount check [medium]

#9 usgeeus closed 4 months ago
2
J_6. use unchecked [optimization]

#8 usgeeus closed 4 months ago
2
J_5. change the way the function return [optimization]

#7 usgeeus closed 4 months ago
2