code-423n4 2021-06-gro-findings issues

code-423n4 / 2021-06-gro-findings

0 stars 1 forks source link

issues

Newest

Newest Most commented Recently updated Oldest Least commented Least recently updated

Use of deprecated Chainlink function `latestAnswer`

#126 code423n4 opened 2 years ago
2
`safetyCheck` does not ensure all ratios of prices are healthy

#125 code423n4 closed 2 years ago
2
Gas optimization by avoiding array copying

#124 code423n4 closed 2 years ago
2
Variables `maxIndex` and `minIndex` in `sortVaultsByDelta` are uninitialized

#123 code423n4 closed 2 years ago
2
Use of `tx.origin` for authentication

#122 code423n4 opened 2 years ago
2
More accurate calculation of return USD of `withdrawSingleByLiquidity`

#121 code423n4 opened 2 years ago
0
Add a proper revert message in `_withdrawSingle`

#120 code423n4 opened 2 years ago
2
Possible division-by-zero error in `burnAll` of `RebasingGToken`

#119 code423n4 closed 2 years ago
2
Lack of non-zero address check in `setWithdrawHandler`

#118 code423n4 closed 2 years ago
2
Unlocked pragma used in multiple contracts

#117 code423n4 opened 2 years ago
2
function withdrawToAdapter should be inluded in the interface and return withdrawal amount

#116 code423n4 opened 2 years ago
2
All vaults must be private?

#115 code423n4 closed 2 years ago
2
BaseVaultAdaptor assumes `sharePrice` is always in underlying decimals

#114 code423n4 opened 2 years ago
0
BaseVaultAdaptor withdraws too much

#113 code423n4 closed 2 years ago
2
`BaseVaultAdaptor.strategiesLength` must be updated manually

#112 code423n4 closed 2 years ago
2
`LifeGuard3Pool.investSingle` can be sandwich attacked

#111 code423n4 closed 2 years ago
2
strategiesLength should not be allowed to exceed MAX_STRATS

#110 code423n4 opened 2 years ago
2
`calcProtocolWithdraw` withdraws more than necessary?

#109 code423n4 closed 2 years ago
2
Rational actors will just set themselves as referral

#108 code423n4 opened 2 years ago
2
Early user can break minting

#107 code423n4 opened 2 years ago
2
Usage of deprecated ChainLink API in `Buoy3Pool`

#106 code423n4 opened 2 years ago
0
`Buoy3Pool._updateRatios` unsafe math

#105 code423n4 opened 2 years ago
2
`Buoy3Pool.safetyCheck` is not precise and has some assumptions

#104 code423n4 opened 2 years ago
3
`Buoy3Pool.safetyCheck` can underflow

#103 code423n4 closed 2 years ago
3
`Allocaiton.calcProtocolExposureDelta` gas optimization

#102 code423n4 opened 2 years ago
0
`Exposure.sortVaultsByDelta` does not work for N_COINS != 3

#101 code423n4 opened 2 years ago
2
Underlying token percents should add up to 100% / `exposure.sortVaultsByDelta` tracking does not work

#100 code423n4 closed 2 years ago
3
`Exposure.sortVaultsByDelta` can underflow

#99 code423n4 closed 2 years ago
2
`Insurance.getVaultDeltaForDeposit` returns wrong `investDelta`

#98 code423n4 opened 2 years ago
3
Wrong min amount check in `withdrawByStablecoin`

#97 code423n4 opened 2 years ago
2
Hardcoded 99 as deadcoin

#96 code423n4 opened 2 years ago
2
Loss of precision

#95 code423n4 opened 2 years ago
2
Unused Controller events

#94 code423n4 closed 2 years ago
2
Unused LifeGuard3Pool events

#93 code423n4 closed 2 years ago
2
Unused Vault events

#92 code423n4 closed 2 years ago
2
RebasingGToken emits same events on transfer

#91 code423n4 opened 2 years ago
0
Missing parameter validation

#90 code423n4 opened 2 years ago
1
Uneccessary loop in Buoy3Pool._stableToLp

#89 code423n4 closed 2 years ago
2
event LogTransfer is only emitted in function transfer

#88 code423n4 opened 2 years ago
0
burnAll should check that factor > 0 and amount > 0

#87 code423n4 opened 2 years ago
2
totalAssets > withdrawUsd should be inclusive

#86 code423n4 opened 2 years ago
2
Inconsistent Usage of CONSTANT naming in Buoy3Pool

#85 code423n4 closed 2 years ago
1
Two SafeApprove calls when it could be just one

#84 code423n4 opened 2 years ago
1
Inconsistent usage of exponentiation for constants

#83 code423n4 opened 2 years ago
0
Return False early in isValidBigFish

#82 code423n4 opened 2 years ago
0
For chainlink oracle, use latestRoundData instead of latestAnswer to run more validations

#81 code423n4 closed 2 years ago
2
setBigFishThreshold above 100%

#80 code423n4 opened 2 years ago
0
No way of removing an address from safeAddresses

#79 code423n4 closed 2 years ago
2
withdrawal fee may be set above 100% or frontrunned

#78 code423n4 opened 2 years ago
2
decimals of FixedStablecoins

#77 code423n4 opened 2 years ago
1