issues
search
code-423n4
/
2022-04-badger-citadel-findings
0
stars
1
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
test
#239
ankushgoel27
closed
1 year ago
0
Agreements & Disclosures
#238
CloudEllie
opened
2 years ago
0
Upgraded Q -> H from 41 [1655143123011]
#237
code423n4
closed
2 years ago
0
`StakedCitadelVester.sol` Not implemented IVesting interface.
#236
jack-the-pug
closed
2 years ago
2
QA Report
#235
code423n4
opened
2 years ago
0
QA Report
#234
code423n4
opened
2 years ago
0
Gas Optimizations
#233
code423n4
opened
2 years ago
0
Gas Optimizations
#232
code423n4
opened
2 years ago
0
QA Report
#231
code423n4
opened
2 years ago
0
Gas Optimizations
#230
code423n4
opened
2 years ago
0
Gas Optimizations
#229
code423n4
opened
2 years ago
0
Funding.citadelPriceInAsset can quickly become stale while its update can be front run
#228
code423n4
closed
2 years ago
1
QA Report
#227
code423n4
opened
2 years ago
0
Gas Optimizations
#226
code423n4
opened
2 years ago
0
Users wont be able to withdraw staked tokens since vesting function is called differently in interface and implementation
#225
code423n4
closed
2 years ago
2
Gas Optimizations
#224
code423n4
opened
2 years ago
0
QA Report
#223
code423n4
opened
2 years ago
0
TokenInLimit can be set higher than what the contract has to sell
#222
code423n4
closed
2 years ago
2
Gas Optimizations
#221
code423n4
closed
2 years ago
1
QA Report
#220
code423n4
opened
2 years ago
0
Funding.getAmountOut returns zero when there is no discount set
#219
code423n4
closed
2 years ago
2
If the funding discount is set to 0 in Funding.sol, getAmountOut() will return always 0, no matter the amount of asset in.
#218
code423n4
closed
2 years ago
2
StakedCitadel depositors can be attacked by the first depositor with depressing of vault token denomination
#217
code423n4
opened
2 years ago
3
If there is no discount then buying citadel in funding will always return 0 citadel
#216
code423n4
closed
2 years ago
2
The name of the function to setup a vesting in the interface IVesting.sol doesn’t match with the name of the function to setup a vesting in StakeCitadelVester.sol.
#215
code423n4
closed
2 years ago
2
Funding pools, stakers, and lockers could lose Citadel tokens they deserve with `mintAndDistribute`
#214
code423n4
closed
2 years ago
2
QA Report
#213
code423n4
opened
2 years ago
0
QA Report
#212
code423n4
opened
2 years ago
0
Gas Optimizations
#211
code423n4
opened
2 years ago
0
StakedCitadel withdraw burns extra shares on Strategy liquidity issues
#210
code423n4
closed
2 years ago
6
Gas Optimizations
#209
code423n4
opened
2 years ago
0
the governance can mint citadel tokens for themselves
#208
code423n4
closed
2 years ago
1
QA Report
#207
code423n4
opened
2 years ago
0
QA Report
#206
code423n4
opened
2 years ago
0
admin can rug
#205
code423n4
closed
2 years ago
1
Gas Optimizations
#204
code423n4
opened
2 years ago
0
Gas Optimizations
#203
liveactionllama
closed
2 years ago
2
Reliance on ERC20Upgradable.decimals() will always return 18 despite actual token decimals
#202
code423n4
closed
2 years ago
1
Economic calculation may not be precise enough
#201
code423n4
closed
2 years ago
1
Gas Optimizations
#200
code423n4
opened
2 years ago
0
QA Report
#199
code423n4
opened
2 years ago
0
earn can be called many times
#198
code423n4
closed
2 years ago
1
`StakedCitadelVester/claimableBalance()` has problems when users keep vesting.
#197
code423n4
closed
2 years ago
2
Gas Optimizations
#196
code423n4
opened
2 years ago
0
Removing Provider could lead to no provider at all
#195
code423n4
closed
2 years ago
1
users lose money in withdraw
#194
code423n4
closed
2 years ago
2
Gas Optimizations
#193
code423n4
opened
2 years ago
0
`_mintSharesFor` doesn’t check whether the `pool` is zero.
#192
code423n4
closed
2 years ago
2
QA Report
#191
code423n4
opened
2 years ago
0
In the citadelMinter there is a missing check on the `mintAndDistribute ()` function
#190
code423n4
closed
2 years ago
3
Next