issues
search
code-423n4
/
2021-09-defiprotocol-findings
1
stars
0
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Missing support for (preventing) use of deflationary tokens in baskets
#177
code423n4
opened
2 years ago
1
Risk of duplicate/scam basket token names/symbols may trick users
#176
code423n4
opened
2 years ago
1
Mismatch between implementation & specification/documentation
#175
code423n4
closed
2 years ago
2
Hardcoded constants are risky
#174
code423n4
opened
2 years ago
2
Missing sanity/threshold checks on critical contract parameter initializations
#173
code423n4
opened
2 years ago
1
Missing timelocks for critical protocol parameter setters by owner
#172
code423n4
opened
2 years ago
1
Missing events for critical protocol parameter setters by owner
#171
code423n4
opened
2 years ago
1
Lack of maxLicenseFee to protect users against greedy publishers
#170
code423n4
closed
2 years ago
1
Lack of indexed event parameters will affect offchain monitoring
#169
code423n4
opened
2 years ago
2
Incorrect data location specifier can be abused to cause DoS and fund loss
#168
code423n4
opened
2 years ago
2
Unhandled return value of transfer() could cause bounty payment failure
#167
code423n4
closed
2 years ago
1
Gas Optimization Via Slot Consolidation
#166
code423n4
closed
2 years ago
1
Bounty list is never pruned to remove inactive bounties
#165
code423n4
opened
2 years ago
1
Missing interfaces to determine available bounties
#164
code423n4
opened
2 years ago
2
Event params are of no practical value
#163
code423n4
opened
2 years ago
1
Malicious tokens can execute arbitrary code
#162
code423n4
opened
2 years ago
3
Missing input validation on token address and amount
#161
code423n4
closed
2 years ago
2
Gas Optimization Wrt. Token Uniqueness
#160
code423n4
opened
2 years ago
1
Transferring only required differences will avoid excessive fund transfer
#159
code423n4
closed
2 years ago
2
Missing equality check on lengths of tokens/weights arrays
#158
code423n4
closed
2 years ago
2
Missing check for auctionOngoing is risky
#157
code423n4
opened
2 years ago
1
Unused constant
#156
code423n4
opened
2 years ago
2
Avoiding redundant parameter/argument can save gas
#155
code423n4
closed
2 years ago
1
Choose either explicit return or named return, not both
#154
code423n4
opened
2 years ago
1
Avoiding unnecessary return can save gas
#153
code423n4
opened
2 years ago
1
Use unchecked{} where the underlying arithmetic can be determined to not overflow/underflow
#152
code423n4
closed
2 years ago
2
Loop can be skipped for i == 0
#151
code423n4
opened
2 years ago
1
Unnecessary initialization of loop index variable
#150
code423n4
opened
2 years ago
1
Using delete to clear variables instead of zero assignment
#149
code423n4
opened
2 years ago
1
Rearranging state variable declaration order will allow slot packing to save gas
#148
code423n4
closed
2 years ago
1
Caching return values of external calls in local/memory variables avoids CALLs to save gas
#147
code423n4
opened
2 years ago
1
Publisher May Accidentally Publish New Index With Incorrect Token Decimals
#146
code423n4
closed
2 years ago
2
Caching state variables in local/memory variables avoids SLOADs to save gas
#145
code423n4
opened
2 years ago
1
Change public visibility to external
#144
code423n4
closed
2 years ago
1
Avoiding state variables in emits saves gas
#143
code423n4
opened
2 years ago
1
Avoiding initializations to default values will save gas
#142
code423n4
closed
2 years ago
1
State variables can be made immutable
#141
code423n4
closed
2 years ago
1
Missing zero-address checks
#140
code423n4
closed
2 years ago
2
Lack of guarded launch approach may be risky
#139
code423n4
opened
2 years ago
1
Single-step process for critical Factory ownership transfers is risky
#138
code423n4
closed
2 years ago
2
`Auction.sol#initialize()` Use msg.sender rather than factory_ parameter can save gas
#137
code423n4
opened
2 years ago
1
`Auction.sol#settleAuction()` Mishandling bounty state could potentially disrupt `settleAuction()`
#136
code423n4
opened
2 years ago
2
Adding unchecked directive can save gas
#135
code423n4
opened
2 years ago
1
`Basket.sol#auctionBurn()` A failed auction will freeze part of the funds
#134
code423n4
opened
2 years ago
1
`Basket.sol#handleFees()` Cache external call results can save gas
#133
code423n4
closed
2 years ago
1
`validateWeights()` Cache length in the for loops can save gas
#132
code423n4
closed
2 years ago
1
`validateWeights()` Limit loop to a meaningful bound can save gas
#131
code423n4
closed
2 years ago
1
Use free functions to replace external calls can save gas
#130
code423n4
closed
2 years ago
2
Fee calculation is potentially incorrect
#129
code423n4
opened
2 years ago
1
Provide meaningful error messages for every exception
#128
code423n4
closed
2 years ago
2
Previous
Next